Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost tasks after put/take/release #65

Closed
oleg-jukovec opened this issue Sep 6, 2023 · 0 comments · Fixed by #66
Closed

Lost tasks after put/take/release #65

oleg-jukovec opened this issue Sep 6, 2023 · 0 comments · Fixed by #66
Assignees
@oleg-jukovec
Labels
2sp bug Something isn't working teamE

Comments

@oleg-jukovec
Copy link
Contributor

fifottl driver + ttr, but without ttl.
oleg-jukovec added a commit that referenced this issue Sep 6, 2023
@oleg-jukovec
fifottl: fix release/bury next_event setup
2c7b397 
`take` sets up the next event time as current time + `ttr`, while
`release` and `bury` do not update the next event time. This can lead
to a task being deleted after `take time` + `ttr` after `release`
or `bury` in the queue fiber.

To fix the issue we can copy approach from the `queue` module [1][2].

1. https://github.com/tarantool/queue/blob/481b5fbf47a7db5c504c64a688b4f8a5fc765a45/queue/abstract/driver/fifottl.lua#L348-L351
2. https://github.com/tarantool/queue/blob/481b5fbf47a7db5c504c64a688b4f8a5fc765a45/queue/abstract/driver/fifottl.lua#L367-L370

Closes #65
@oleg-jukovec oleg-jukovec self-assigned this Sep 6, 2023
@oleg-jukovec oleg-jukovec added teamE bug Something isn't working 2sp labels Sep 6, 2023
@oleg-jukovec oleg-jukovec mentioned this issue Sep 6, 2023
Merged
oleg-jukovec added a commit that referenced this issue Sep 6, 2023
@oleg-jukovec
fifottl: fix release/bury next_event setup
0ed3a19 
`take` sets up the next event time as current time + `ttr`, while
`release` and `bury` do not update the next event time. This can lead
to a task being deleted after `take time` + `ttr` after `release`
or `bury` in the queue fiber.

To fix the issue we can copy approach from the `queue` module [1][2].

1. https://github.com/tarantool/queue/blob/481b5fbf47a7db5c504c64a688b4f8a5fc765a45/queue/abstract/driver/fifottl.lua#L348-L351
2. https://github.com/tarantool/queue/blob/481b5fbf47a7db5c504c64a688b4f8a5fc765a45/queue/abstract/driver/fifottl.lua#L367-L370

Closes #65
oleg-jukovec added a commit that referenced this issue Sep 6, 2023
@oleg-jukovec
Release 0.1.1
87b9544 
    The release fixes the loss of tasks in the `fifottl` driver.

Breaking changes

    None.

Bugfixes

    A deletion of a released task after `ttr` in the `fifottl`
    driver (#65).
@oleg-jukovec oleg-jukovec mentioned this issue Sep 6, 2023
Merged
oleg-jukovec added a commit that referenced this issue Sep 6, 2023
@oleg-jukovec
Release 0.1.1
09b5fe0 
    The release fixes the loss of tasks in the `fifottl` driver.

Breaking changes

    None.

Bugfixes

    A deletion of a released task after `ttr` in the `fifottl`
    driver (#65).
oleg-jukovec added a commit that referenced this issue Sep 6, 2023
@oleg-jukovec
Release 0.1.1
cc77d61 
    The release fixes the loss of tasks in the `fifottl` driver.

Breaking changes

    None.

Bugfixes

    A deletion of a released task after `ttr` in the `fifottl`
    driver (#65).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg-jukovec oleg-jukovec

Labels
2sp bug Something isn't working teamE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fifottl: fix release/bury next_event setup tarantool/sharded-queue
1 participant
@oleg-jukovec