Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add _VERSION field to roles #58

Merged
merged 1 commit into from
Jun 13, 2023
Merged

api: add _VERSION field to roles #58

merged 1 commit into from
Jun 13, 2023
+38 −0

Conversation

oleg-jukovec
Copy link
Contributor

No description provided.

@oleg-jukovec oleg-jukovec marked this pull request as ready for review June 8, 2023 22:13
GRISHNOV
GRISHNOV approved these changes Jun 13, 2023
View reviewed changes
Copy link

@GRISHNOV GRISHNOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as far as I understand, checking the relevance of tags via CI will be implemented later. Last quarter, _VERSION was not implemented in this repository due to no tags

@oleg-jukovec oleg-jukovec merged commit 9f1a7c8 into master Jun 13, 2023
@oleg-jukovec oleg-jukovec deleted the oleg-jukovec/version branch June 16, 2023 12:22
@oleg-jukovec oleg-jukovec mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@better0fdead better0fdead better0fdead approved these changes

@GRISHNOV GRISHNOV GRISHNOV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleg-jukovec @GRISHNOV @better0fdead