cluster discovery: don't discard the entire result when there are bad addresses #195
Labels
feature
A new functionality
Comments
nicktorwald
added a commit
that referenced
this issue
Jun 3, 2019
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips this broken address and carries on processing. Change discovery function requirements description in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #195, #196
nicktorwald
added a commit
that referenced
this issue
Jun 4, 2019
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Discard a single string return type for a cluster discovery function. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #195, #196
nicktorwald
added a commit
that referenced
this issue
Jun 11, 2019
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Discard a single string return type for a cluster discovery function. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #195, #196
nicktorwald
added a commit
that referenced
this issue
Jun 12, 2019
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Discard a single string return type for a cluster discovery function. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #195, #196
nicktorwald
added a commit
that referenced
this issue
Jun 18, 2019
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Closes: #195
nicktorwald
added a commit
that referenced
this issue
Jun 19, 2019
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Closes: #195
nicktorwald
added a commit
to nicktorwald/tarantool-java
that referenced
this issue
Jul 1, 2019
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Closes: tarantool#195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We discussed whether we need to discard the entire result of just an address when some of addresses don't pass a validation in the scope of MeshConnection in tarantool-python (PR). (Under the word 'validation' I mean whether an address is a string that matches
.+:\d+and the port is not zero, nothing about corresponding instance availability.) We decided to warn about bad addresses and apply correct ones. I hope cluster clients in different languages should have similar behaviour where possible, so propose to bahve in this way in tarantool-java too.To be honest I don't think this is important thing, but consistency between connectors is important.
The text was updated successfully, but these errors were encountered: