Skip to content

build: run javadoc linter in local testing and CI #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Totktonada opened this issue Nov 19, 2019 · 0 comments · Fixed by #255
Closed

build: run javadoc linter in local testing and CI #244

Totktonada opened this issue Nov 19, 2019 · 0 comments · Fixed by #255
Labels
code health Improve code readability, simplify maintenance and so on good first issue Good for newcomers testing

Comments

@Totktonada
Copy link
Member

I recently found that I'm unable to prepare a release (mvn release:clean release:prepare -DpushChanges=false) because of javadoc linter errors (see PR #243). It would be good to catch those errors (and also warnings) during development.

I don't know how to run a javadoc linter separately from release:prepare. Maybe we need to extract necessary parts of oss-parent POM to our POM file: if so, this issue looks connected with #241.
@Totktonada Totktonada added code health Improve code readability, simplify maintenance and so on testing labels Nov 19, 2019
@Totktonada Totktonada mentioned this issue Nov 19, 2019
Open
@Totktonada Totktonada added the good first issue Good for newcomers label Sep 1, 2020
Artyomcool pushed a commit to Artyomcool/tarantool-java that referenced this issue Sep 1, 2020
Fixes tarantool#244: run javadoc linter with travis
cca7bb0
Artyomcool pushed a commit to Artyomcool/tarantool-java that referenced this issue Sep 1, 2020
Fixes tarantool#244: run javadoc linter with travis
ab8a8dc
Artyomcool pushed a commit to Artyomcool/tarantool-java that referenced this issue Sep 1, 2020
travis-ci: run javadoc linter with travis
137811c 
Fixes: tarantool#244
@Artyomcool Artyomcool mentioned this issue Sep 1, 2020
Merged
Totktonada pushed a commit that referenced this issue Sep 1, 2020
@Totktonada
travis-ci: run javadoc linter with travis
a984846 
Fixes: #244
@Totktonada Totktonada mentioned this issue Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Improve code readability, simplify maintenance and so on good first issue Good for newcomers testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

travis-ci: run javadoc linter with travis Artyomcool/tarantool-java
1 participant
@Totktonada