jdbc: NPE when trying to execute update

[ztarvos]

Driver throws null pointer exception when trying to execute update (either DML or DDL).

Statement stmt = conn.createStatement();
int count = stmt.executeUpdate("CREATE TABLE test(id INT PRIMARY KEY, val VARCHAR(20))");

Exception in thread "main" java.lang.NullPointerException at org.tarantool.JDBCBridge.update(JDBCBridge.java:38) at org.tarantool.jdbc.SQLStatement.executeUpdate(SQLStatement.java:35) at TestJdbcUpdate.main(TestJdbcUpdate.java:18)

Probably the constants related to IPROTO in the driver are somewhat obsolete.

[Khatskevich]

The problem is simpler.
It is fixed in brunch https://github.com/tarantool/tarantool-java/tree/kh/fix_dml

[ztarvos]

Hi!
Actually, I do not see how these changes fix the issue. Probably a test would help.
My own test finally worked when I changed the two constants in Key.java to be in sync with the fresh tarantool 2.0 branch, namely SQL_INFO(0x42) and SQL_ROW_COUNT(0). It even did return correct row count back.

[Khatskevich]

Great! Patches are welcome)

P.S. I did not investigate the issue deeply. My patch just let me run my own tests.

[ztarvos]

Sure, I will prepare a patch.
Thanks!

[Totktonada]

@ztarvos Any updates? I see you created the patch. Are you going to open the pull request?

It seems the constants was changed on tarantool side? So, we'll break compatibility with older version if will update them here. What version of tarantool changes it?

[ztarvos]

Hi!

@ztarvos Any updates? I see you created the patch. Are you going to open the pull request?

I was hoping to see the test infrastructure merged to the jdbc branch first (PR#50) so I can base my changes on it. My fix contains integration tests which require a tarantool instance running. It will not work without it.

It seems the constants was changed on tarantool side? So, we'll break compatibility with older version if will update them here. What version of tarantool changes it?

These constants are related to SQL and only present on the connector-1.8jdbc branch of tarantool-java, so I guess nothing is broken. For tarantool itself, I think they appeared in 2.0.

[Totktonada]

Merged initial test infrastructure with #50.