WIP: Fetch list of nodes in a cluster client #129
Conversation
methods in TarantoolClusterClient
Totktonada
changed the title
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.2</version> | ||
| <version>3.6.1</version> <!--incresed from 3.2 due to lack of annotation processing support--> |
There was a problem hiding this comment.
This comment is more appropriate for a commit message.
| /** | ||
| * Array of addresses in the form of [host]:[port]. | ||
| */ | ||
| public String[] slaveHosts; |
There was a problem hiding this comment.
The master-slave terminology is in use for replication, so we should not use it here. I think we can use just 'hosts' (it is addrs—host and port—if we want to be strict) and 'entrypoint'.
| */ | ||
| public TarantoolClusterClient(TarantoolClusterClientConfig config, String... addrs) { | ||
| this(config, new RoundRobinSocketProviderImpl(addrs).setTimeout(config.operationExpiryTimeMillis)); | ||
| public TarantoolClusterClient(TarantoolClusterClientConfig config) { |
There was a problem hiding this comment.
Just note for now: here we break backward compatibility w/o a visible reason (nothing prevent us from receiving addrs and save here into a configuration if provided).
| * @return the result of SocketChannel open(SocketAddress remote) call | ||
| */ | ||
| SocketChannel get(int retryNumber, Throwable lastError); | ||
| SocketChannel get(); |
There was a problem hiding this comment.
Hmhm. What is the motivation of this change?
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class ClusterTopologyFromShardDiscovererImpl implements ClusterTopologyDiscoverer { |
There was a problem hiding this comment.
We don't discussed any predefined actions around sharding. What is this class and why?
The discussion was about a replication cluster and box.info.replication.
| <includeBaseDirectory>false</includeBaseDirectory> | ||
| <dependencySets> | ||
| <dependencySet> | ||
| <outputDirectory>/</outputDirectory> |
There was a problem hiding this comment.
Why /? Maybe target or testroot is better?
| <fileSets> | ||
| <fileSet> | ||
| <directory>${project.build.directory}/test-classes</directory> | ||
| <outputDirectory>/</outputDirectory> |
There was a problem hiding this comment.
The same question here: why /?
| public static final int majorVersion = ${parsedVersion.majorVersion}; | ||
| public static final int minorVersion = ${parsedVersion.minorVersion}; | ||
| public static final int majorVersion = Integer.parseInt("${parsedVersion.majorVersion}"); | ||
| public static final int minorVersion = Integer.parseInt("${parsedVersion.minorVersion}"); |
There was a problem hiding this comment.
Don't add this file into sources manually. IDEA find a generated file when the project is added as maven project. Please, revert this hunk.
… SingleNodeConnectionProvider -> SingleInstanceConnectionProvider
ponomarevDmitri
force-pushed
the
support_for_tarantool_clusters_(benchmarks)
branch
from
00c2f49 to
65db6ab
Compare
NUMERIC/DATE-related types were removed and BLOB type was replaced by SCALAR in scope of new SQL type changes. See tarantool/tarantool#4019 for more information. Fixes tarantool#130. (cherry picked from commit d2dfa4c)
|
Superseded by PR #136. |
3 participants
No description provided.