Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed checks on methods of the closed connection #153

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Add missed checks on methods of the closed connection #153

merged 1 commit into from
Apr 19, 2019

Conversation

nicktorwald
Copy link

@nicktorwald nicktorwald commented Apr 8, 2019 •
edited
Loading

Add missed checks on methods of the closed connection.

Closes: #72
Affects: #119, #74

@nicktorwald nicktorwald changed the title Add missed checks on methods of the closed connection. Add missed checks on methods of the closed connection Apr 8, 2019
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-72-closed-connection branch from 3dbee96 to 42c9276 Compare April 8, 2019 18:44
@coveralls
Copy link

coveralls commented Apr 8, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.5%) to 62.613% when pulling 00232b7 on nicktorwald/gh-72-closed-connection into 06755d5 on master.

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-72-closed-connection branch 2 times, most recently from a616415 to 00232b7 Compare April 9, 2019 04:20
@nicktorwald nicktorwald requested a review from Totktonada April 10, 2019 06:59
Totktonada
Totktonada reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please, fix the PR description.

src/main/java/org/tarantool/jdbc/SQLConnection.java Outdated Show resolved Hide resolved
src/main/java/org/tarantool/jdbc/SQLConnection.java Show resolved Hide resolved
src/main/java/org/tarantool/jdbc/SQLConnection.java Show resolved Hide resolved
src/test/java/org/tarantool/jdbc/JdbcConnectionIT.java Outdated Show resolved Hide resolved
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-72-closed-connection branch from 00232b7 to 25c0875 Compare April 17, 2019 20:02
@nicktorwald
Raise SQLException on methods of a closed Connection
c047043 
Add missed checks on methods of the closed connection.

Closes: #72
Affects: #119, #74
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-72-closed-connection branch from 25c0875 to c047043 Compare April 18, 2019 19:11
@nicktorwald nicktorwald requested a review from Totktonada April 18, 2019 19:11
@nicktorwald nicktorwald merged commit aaa404a into master Apr 19, 2019
@Totktonada Totktonada deleted the nicktorwald/gh-72-closed-connection branch April 19, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jdbc: Raise SQLException on Connection methods for a closed connection
3 participants
@nicktorwald @coveralls @Totktonada