Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TConnection with TClientImpl in JDBC #172

Merged
merged 1 commit into from
May 21, 2019

Conversation

nicktorwald
Copy link

Replace obsolete TarantoolConnection with TarantoolClient to have an
ability to perform async operations.

Update SQLDriver URL parameters. Add init and operation timeouts.
Remove socket timeout and replace socket provider with socket channel
provider options (according to TarantoolConnection-to-TarantoolClient
transfer written above).

Add operation timeout capability to TarantoolClientImpl. It also affects
the cluster client which no more needs its own expirable operations.

Add base support for SQLStatement (setQueryTimeout) to execute requests
with timeout using new TarantoolClient operation timeout.

Remove deprecated JDBCBridge. SQLConnection accepted the responsibility
for producing raw SQL results.

Update README doc with respect to JDBC driver options changes.

Closes: #163
Follows on: #75, #155

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-remove-tnt-connection branch from 97220b4 to dfd8bbc Compare April 30, 2019 18:42
@coveralls
Copy link

coveralls commented Apr 30, 2019

Coverage Status

Coverage increased (+0.6%) to 70.422% when pulling 0328ca9 on nicktorwald/gh-163-remove-tnt-connection into 1cafd58 on master.

@Totktonada
Copy link
Member

Maybe we misunderstood each other. I would leave TarantoolConnection itself for compatibility (say, YSCB use it), but use TarantoolClientImpl in JDBC part of the connector.

@nicktorwald nicktorwald requested a review from Totktonada May 1, 2019 10:33
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-remove-tnt-connection branch from dfd8bbc to 8e38e67 Compare May 2, 2019 10:14
@nicktorwald nicktorwald changed the title Remove TarantoolConnection Replace TConnection with TClientImpl in JDBC May 2, 2019
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-remove-tnt-connection branch 3 times, most recently from d6ded99 to 60d0fc8 Compare May 5, 2019 17:28
@nicktorwald
Copy link
Author

Maybe we misunderstood each other. I would leave TarantoolConnection itself for compatibility (say, YSCB use it), but use TarantoolClientImpl in JDBC part of the connector.

Okay, reverted.

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-remove-tnt-connection branch from 60d0fc8 to 494292b Compare May 8, 2019 11:57
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, try to avoid resorting of methods and such changes: it complexes a code review and garbage git blame. If these changes are needed, move them to a separate commit.

I don't have objections in general. Some comments are below.

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-remove-tnt-connection branch 3 times, most recently from 769d0a8 to 2433ac1 Compare May 15, 2019 08:48
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one comment below.

(Please, don't push until we'll release connector-1.9.2.)

src/main/java/org/tarantool/jdbc/SQLConnection.java Outdated Show resolved Hide resolved
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-remove-tnt-connection branch 2 times, most recently from 26d241e to d38c098 Compare May 19, 2019 17:51
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-remove-tnt-connection branch 4 times, most recently from f96f594 to 0328ca9 Compare May 20, 2019 16:34
Replace obsolete TarantoolConnection with TarantoolClient to have an
ability to perform async operations.

Update SQLDriver URL parameters. Add init and operation timeouts.
Remove socket timeout and replace socket provider with socket channel
provider options (according to TarantoolConnection-to-TarantoolClient
transfer written above).

Add operation timeout capability to TarantoolClientImpl. It also affects
the cluster client which no more needs its own expirable operations.

Add basic support for SQLStatement (setQueryTimeout) to execute requests
with timeout using new TarantoolClient operation timeout.

Remove deprecated JDBCBridge. SQLConnection accepted the responsibility
for producing raw SQL results.

Update README doc with respect to JDBC driver options changes.

Closes: #163
Follows on: #75, #155
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-163-remove-tnt-connection branch from 0328ca9 to 7d4e268 Compare May 21, 2019 18:01
@nicktorwald nicktorwald merged commit e32b3d8 into master May 21, 2019
@nicktorwald nicktorwald deleted the nicktorwald/gh-163-remove-tnt-connection branch May 21, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate TarantoolConnection in SQLConnection
3 participants