-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace TConnection with TClientImpl in JDBC #172
Conversation
97220b4
to
dfd8bbc
Compare
Maybe we misunderstood each other. I would leave TarantoolConnection itself for compatibility (say, YSCB use it), but use TarantoolClientImpl in JDBC part of the connector. |
dfd8bbc
to
8e38e67
Compare
d6ded99
to
60d0fc8
Compare
Okay, reverted. |
60d0fc8
to
494292b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, try to avoid resorting of methods and such changes: it complexes a code review and garbage git blame. If these changes are needed, move them to a separate commit.
I don't have objections in general. Some comments are below.
769d0a8
to
2433ac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one comment below.
(Please, don't push until we'll release connector-1.9.2.)
26d241e
to
d38c098
Compare
f96f594
to
0328ca9
Compare
Replace obsolete TarantoolConnection with TarantoolClient to have an ability to perform async operations. Update SQLDriver URL parameters. Add init and operation timeouts. Remove socket timeout and replace socket provider with socket channel provider options (according to TarantoolConnection-to-TarantoolClient transfer written above). Add operation timeout capability to TarantoolClientImpl. It also affects the cluster client which no more needs its own expirable operations. Add basic support for SQLStatement (setQueryTimeout) to execute requests with timeout using new TarantoolClient operation timeout. Remove deprecated JDBCBridge. SQLConnection accepted the responsibility for producing raw SQL results. Update README doc with respect to JDBC driver options changes. Closes: #163 Follows on: #75, #155
0328ca9
to
7d4e268
Compare
Replace obsolete TarantoolConnection with TarantoolClient to have an
ability to perform async operations.
Update SQLDriver URL parameters. Add init and operation timeouts.
Remove socket timeout and replace socket provider with socket channel
provider options (according to TarantoolConnection-to-TarantoolClient
transfer written above).
Add operation timeout capability to TarantoolClientImpl. It also affects
the cluster client which no more needs its own expirable operations.
Add base support for SQLStatement (setQueryTimeout) to execute requests
with timeout using new TarantoolClient operation timeout.
Remove deprecated JDBCBridge. SQLConnection accepted the responsibility
for producing raw SQL results.
Update README doc with respect to JDBC driver options changes.
Closes: #163
Follows on: #75, #155