Skip to content

Support Statement.closeOnCompletion. #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2019

Conversation

nicktorwald
Copy link

Check a statement after a dependent result set is closed.

Extract TarantoolStatement as tarantool specific extension interface to
be used for internal purposes as well as JDBC incompatible vendor API.

Closes: #180

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-180-close-on-completion branch from fb7a228 to 5f037f0 Compare May 12, 2019 19:09
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 70.61% when pulling 5f037f0 on nicktorwald/gh-180-close-on-completion into 0ee7b30 on master.

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question because of curiosity.

@nicktorwald nicktorwald force-pushed the nicktorwald/gh-180-close-on-completion branch 3 times, most recently from 0337b36 to 7e092f2 Compare May 19, 2019 18:50
Check a statement after all its dependent result set are closed.

Extract TarantoolStatement as tarantool specific extension interface to
be used for internal purposes (incompatible vendor API).

Closes: #180
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-180-close-on-completion branch from 7e092f2 to bf49893 Compare May 21, 2019 18:35
@nicktorwald nicktorwald merged commit 1d131c3 into master May 21, 2019
@nicktorwald nicktorwald deleted the nicktorwald/gh-180-close-on-completion branch May 21, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdbc: Support Statement.closeOnCompletion
3 participants