Support generated keys from INSERT query #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktorwald
force-pushed
the
nicktorwald/gh-77-generated-keys
branch
2 times, most recently
from
13b829c to
ea2a9c3
Compare
Totktonada
approved these changes
Aug 6, 2019
nicktorwald
changed the title
Implement several ResultSetMetaData methods to be able be run as a proper JDBC-driver inside Base tool. Reworked SQL data types in relation with Tarantool NoSQL types as well as JDBC types. A data conversations are left out of this commit. This issue also addresses to tarantool/tarantool#3292 to be executed in a dry-run mode. LibreOffice Base uses PreparedStatement.getMetadata() without a real query execution to extract a metadata in advance. This causes NPE in #198. Follows on: #198
Parse the 'generated_ids' array which is returned after successful INSERT command has applied. This makes sense when a table primary key has an autoincrement property. The driver always returns a predefined result set with a single-column table (column name is 'GENERATED_KEYS') where each row is one generated value. Closes: #77
nicktorwald
force-pushed
the
nicktorwald/gh-77-generated-keys
branch
from
ea2a9c3 to
35ad713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the 'generated_ids' array which is returned after successful
INSERT command has applied. This makes sense when a table primary key
has an autoincrement property. The driver always returns a predefined
result set with a single-column table (column name is 'GENERATED_KEYS')
where each row is one generated value.
Closes: #77