Skip to content

add tests for basic connector functionality #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2018
Merged

add tests for basic connector functionality #88

merged 1 commit into from
Nov 21, 2018

Conversation

ztarvos
Copy link

@ztarvos ztarvos commented Nov 7, 2018

Added tests for connector API.
Fixed involuntary re-connects issue.

Closes #51

@ztarvos ztarvos requested a review from Totktonada November 7, 2018 14:44
Totktonada
Totktonada reviewed Nov 13, 2018
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but I want ask you to split out code and test changes (if it is possible), discuss how tarantool should be started/stopped to test reconnection and note some minor details.

@ztarvos ztarvos force-pushed the gh-51-add-basic-connector-tests branch 2 times, most recently from e8cbebc to fe03060 Compare November 16, 2018 15:09
@ztarvos
Copy link
Author

ztarvos commented Nov 16, 2018

@Totktonada Alexander, please take a look at the code again. I have resolved most of the issues.

@Totktonada Totktonada mentioned this pull request Nov 19, 2018
Closed
@ztarvos ztarvos force-pushed the gh-51-add-basic-connector-tests branch from fe03060 to d2f403a Compare November 19, 2018 13:16
Totktonada
Totktonada approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ztarvos The tests looks good for me. I have the proposal how to run tests locally w/o extra manual steps to get a tarantool instance running. I'll hold the PR to catch your opinion on that.

@ztarvos
add tests for basic connector functionality
c0f3d12 
Added tests for connector API.

Closes #51
@ztarvos ztarvos force-pushed the gh-51-add-basic-connector-tests branch from d2f403a to c0f3d12 Compare November 19, 2018 17:53
@Totktonada
Copy link
Member

Hmm, it stucks second time (I restarted the job) on oraclejdk11 on ClientReconnectIT. It seems it has some race condition.

https://travis-ci.org/tarantool/tarantool-java/jobs/457086437#L1455

@ztarvos
Copy link
Author

ztarvos commented Nov 20, 2018

Hmm, it stucks second time (I restarted the job) on oraclejdk11 on ClientReconnectIT. It seems it has some race condition.

https://travis-ci.org/tarantool/tarantool-java/jobs/457086437#L1455

This is the reason why I included code changes in my original PR.

@Totktonada
Copy link
Member

This is the reason why I included code changes in my original PR.

Got it. So, ok.

@Totktonada Totktonada merged commit d220ca2 into master Nov 21, 2018
@Totktonada Totktonada deleted the gh-51-add-basic-connector-tests branch November 21, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ztarvos @Totktonada