Skip to content

Commit

Permalink
cleanup: clean code from excessive use of "inline"
Browse files Browse the repository at this point in the history
There is serious "inline disease" in the code.
It seems that "inline" is set to all static function.
The patch clears the tarantool_schema.c file.
  • Loading branch information
LeonidVas committed Jul 17, 2020
1 parent 9a2dd3b commit eee32f0
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/tarantool_schema.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ schema_index_value_free(const struct schema_index_value *val) {
}
}

static inline void
static void
schema_index_free(struct mh_schema_index_t *schema) {
int pos = 0;
mh_int_t index_slot = 0;
Expand Down Expand Up @@ -146,7 +146,7 @@ mh_spacecmp_key_eq(
#define MH_DEBUG 1
#include "third_party/mhash.h"

static inline void
static void
schema_space_value_free(const struct schema_space_value *val) {
if (val) {
pefree(val->space_name, 1);
Expand All @@ -161,7 +161,7 @@ schema_space_value_free(const struct schema_space_value *val) {
}
}

static inline void
static void
schema_space_free(struct mh_schema_space_t *schema) {
int pos = 0;
mh_int_t space_slot = 0;
Expand Down Expand Up @@ -212,7 +212,7 @@ int parse_field_type(const char *sfield, size_t sfield_len) {
return FT_OTHER;
}

static inline int
static int
parse_schema_space_value_value(struct schema_field_value *fld,
const char **tuple) {
uint32_t sfield_len = 0;
Expand Down Expand Up @@ -240,7 +240,7 @@ parse_schema_space_value_value(struct schema_field_value *fld,
return -1;
}

static inline int
static int
parse_schema_space_value(struct schema_space_value *space_string,
const char **tuple) {
uint32_t fmp_tmp_len = 0;
Expand Down Expand Up @@ -269,7 +269,7 @@ parse_schema_space_value(struct schema_space_value *space_string,
return -1;
}

static inline int
static int
parse_schema_index_value(struct schema_index_value *index_string,
const char **tuple) {
if (mp_typeof(**tuple) != MP_ARRAY)
Expand Down Expand Up @@ -304,7 +304,7 @@ parse_schema_index_value(struct schema_index_value *index_string,
return -1;
}

static inline int
static int
schema_add_space(
struct mh_schema_space_t *schema,
const char **data
Expand Down Expand Up @@ -421,7 +421,7 @@ tarantool_schema_add_spaces(
return -1;
}

static inline int schema_add_index(
static int schema_add_index(
struct mh_schema_space_t *schema,
const char **data
) {
Expand Down

0 comments on commit eee32f0

Please sign in to comment.