-
Notifications
You must be signed in to change notification settings - Fork 46
Add forwarding msgpack packer and unpacker to call function #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
added a commit
that referenced
this pull request
Nov 30, 2022
After this patch, user may pass `packer_factory` and `unpacker_factory` options to a connection. They will be used instead of the default ones. `packer_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Packer object. `unpacker_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Unpacker object. `packer_factory` supersedes `encoding` option. `unpacker_factory` supersedes `encoding` and `use_list` options. User may implement `encoding` and `use_list` support in its custom packer or unpacker if they wish so. User may refer to request submodule `packer_factory` and response submodule `unpacker_factory` as an example (these factories are used by default.) Closes #145, #190, #191
DifferentialOrange
added a commit
that referenced
this pull request
Nov 30, 2022
After this patch, user may pass `packer_factory` and `unpacker_factory` options to a connection. They will be used instead of the default ones. `packer_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Packer object. `unpacker_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Unpacker object. `packer_factory` supersedes `encoding` option. `unpacker_factory` supersedes `encoding` and `use_list` options. User may implement `encoding` and `use_list` support in its custom packer or unpacker if they wish so. User may refer to request submodule `packer_factory` and response submodule `unpacker_factory` as an example (these factories are used by default.) Closes #145, #190, #191
DifferentialOrange
added a commit
that referenced
this pull request
Nov 30, 2022
After this patch, user may pass `packer_factory` and `unpacker_factory` options to a connection. They will be used instead of the default ones. `packer_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Packer object. `unpacker_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Unpacker object. `packer_factory` supersedes `encoding` option. `unpacker_factory` supersedes `encoding` and `use_list` options. User may implement `encoding` and `use_list` support in its custom packer or unpacker if they wish so. User may refer to request submodule `packer_factory` and response submodule `unpacker_factory` as an example (these factories are used by default.) Closes #145, #190, #191
DifferentialOrange
added a commit
that referenced
this pull request
Dec 1, 2022
After this patch, user may pass `packer_factory` and `unpacker_factory` options to a connection. They will be used instead of the default ones. `packer_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Packer object. `unpacker_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Unpacker object. `packer_factory` supersedes `encoding` option. `unpacker_factory` supersedes `encoding` and `use_list` options. User may implement `encoding` and `use_list` support in its custom packer or unpacker if they wish so. User may refer to request submodule `packer_factory` and response submodule `unpacker_factory` as an example (these factories are used by default.) Closes #145, #190, #191
DifferentialOrange
added a commit
that referenced
this pull request
Dec 1, 2022
After this patch, user may pass `packer_factory` and `unpacker_factory` options to a connection. They will be used instead of the default ones. `packer_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Packer object. `unpacker_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Unpacker object. `packer_factory` supersedes `encoding` option. `unpacker_factory` supersedes `encoding` and `use_list` options. User may implement `encoding` and `use_list` support in its custom packer or unpacker if they wish so. User may refer to request submodule `packer_factory` and response submodule `unpacker_factory` as an example (these factories are used by default.) Closes #145, #190, #191
DifferentialOrange
added a commit
that referenced
this pull request
Dec 1, 2022
After this patch, user may pass `packer_factory` and `unpacker_factory` options to a connection. They will be used instead of the default ones. `packer_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Packer object. `unpacker_factory` is expected to be a function with the only one parameter: connection object, which returns a new msgpack.Unpacker object. `packer_factory` supersedes `encoding` option. `unpacker_factory` supersedes `encoding` and `use_list` options. User may implement `encoding` and `use_list` support in its custom packer or unpacker if they wish so. User may refer to request submodule `packer_factory` and response submodule `unpacker_factory` as an example (these factories are used by default.) Closes #145, #190, #191
Solved by #268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
For response tuple containing strings and bytes python3 falls with utf-8 decoding exception.
For set encoding=None user should decode string manually after call.
Usage: