Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make feature discovery similar to go-tarantool #296

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Jun 27, 2023

iproto: provide new features codes

Pagination was added in Tarantool 2.11.0-rc1 [1]. Space and index names support will be added to Tarantool 3.0 [2]. Watch once feature will be added to Tarantool 3.0 [3].

  1. tarantool/tarantool@948e5cd
  2. tarantool/tarantool@b9550f1
  3. tarantool/tarantool@6dc1433

conn: store client and server protocol info

Store client and server protocol version and features in connection object, similar to go-tarantool [1]. Before the patch, we stored only products: minimal protocol version of server and client and the list of features supported both by client and server.

  1. api: support iproto feature discovery go-tarantool#226

api: allow to require protocol version and features

Allow to set required_protocol_version and required_features on connection initialization to ensure that a Tarantool server provides expected features. The approach is similar to go-tarantool [1]. We do not check client protocol version and features, similar to the core Tarantool [1, 2].

  1. api: support iproto feature discovery go-tarantool#226
  2. Asymmetric behaviour on unknown client protocol info tarantool#7953

Closes #267

Pagination was added in Tarantool 2.11.0-rc1 [1]. Space and index names
support will be added to Tarantool 3.0 [2]. Watch once feature will be
added to Tarantool 3.0 [3].

1. tarantool/tarantool@948e5cd
2. tarantool/tarantool@b9550f1
3. tarantool/tarantool@6dc1433

Part of #267
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-267-iproto branch 2 times, most recently from c34cb62 to 11735d9 Compare June 27, 2023 12:47
@DifferentialOrange DifferentialOrange changed the title api: allow to require protocol version and features Make feature discovery similar to go-tarantool Jun 27, 2023
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-267-iproto branch 3 times, most recently from c5b7535 to a354d78 Compare June 28, 2023 07:45
Store client and server protocol version and features in connection
object, similar to go-tarantool [1]. Before the patch, we stored only
products: minimal protocol version of server and client and the list
of features supported both by client and server.

1. tarantool/go-tarantool#226

Part of #267
Allow to set required_protocol_version and required_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
@DifferentialOrange DifferentialOrange merged commit e954c4c into master Jun 28, 2023
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/gh-267-iproto branch June 28, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPROTO_ID follow up
2 participants