Fix intervals #302
Merged
Fix intervals #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Interval with week encoding test cases and datetime arithmetic week test case.
Before this patch, weeks were ignored in Interval addition and subtraction. This patch fixes the issue.
oleg-jukovec
approved these changes
Jul 18, 2023
DifferentialOrange
force-pushed
the
DifferentialOrange/fix-intervals
branch
from
9ee4f2a to
95e1fcb
Compare
Before this patch, any value was allowed for interval attributes. Now we use the same rules as in Tarantool. A couple of issues were met while developing this patch, follow [1, 2] for core updates. 1. tarantool/tarantool#8878 2. tarantool/tarantool#8887
DifferentialOrange
force-pushed
the
DifferentialOrange/fix-intervals
branch
from
95e1fcb to
fe0ca6f
Compare
oleg-jukovec
approved these changes
Jul 18, 2023
DifferentialOrange
added a commit
that referenced
this pull request
Jul 19, 2023
Overview
This release introduces various datetime interval fixes and quality of
life improvements.
Breaking changes
- Forbid to create datetime intervals out of Tarantool limits
(PR #302).
Changed
- Validate `tarantool.Interval` limits with the same rules as in
Tarantool (PR #302).
Fixed
- `tarantool.Interval` arithmetic with weeks (PR #302).
- `tarantool.Interval` weeks display in `str()` and `repr()`
(PR #302).
Merged
DifferentialOrange
added a commit
that referenced
this pull request
Jul 19, 2023
Overview
This release introduces various datetime interval fixes and quality of
life improvements.
Breaking changes
- Forbid to create datetime intervals out of Tarantool limits
(PR #302).
Changed
- Validate `tarantool.Interval` limits with the same rules as in
Tarantool (PR #302).
Fixed
- `tarantool.Interval` arithmetic with weeks (PR #302).
- `tarantool.Interval` weeks display in `str()` and `repr()`
(PR #302).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various issues related to datetime interval type. See commits for more info.
Thanks to @ArtDu for reporting these issues.