Add Tarantool 3 support and matrix tests #114
Conversation
|
Add tarantool 3 support Add matrix tests with tarantool 1.x, 2.11.2 and 3.0.1 Change TARANTOOL_VERSION usage (remove -centos7 from template) Add tarantool-container profile for matrix tests Update DEFAULT_IMAGE_VERSION to 2.11.2 Closes #109
iDneprov
force-pushed
the
gh-109-tarantool-3
branch
from
7a6e529 to
693dc13
Compare
|
| @@ -73,31 +74,14 @@ public void testContainerWithParameters() throws Exception { | |||
|
|
|||
| @Test | |||
| public void testContainerWithTrueVersion() throws Exception { | |||
There was a problem hiding this comment.
In matrix tests env var TARANTOOL_VERSION always set. So this test is redundant.
| List<String> result; | ||
| try (TarantoolContainer container = new TarantoolContainer()) { | ||
| container.start(); | ||
| result = container.executeCommandDecoded("return _TARANTOOL"); | ||
| } | ||
|
|
||
| assertEquals(1, result.size()); | ||
| assertTrue(result.get(0).startsWith(TarantoolContainer.DEFAULT_IMAGE_VERSION)); | ||
| assertTrue(result.get(0).startsWith(String.valueOf(tarantoolVersion.charAt(0)))); |
There was a problem hiding this comment.
What if these are not CI tests with predefined Tarantool versions, and there is no TARANTOOL_VERSION variable on the system on which the test runs? It seems that a NullPointerException is possible
|
| @@ -32,6 +32,7 @@ jobs: | |||
| env: | |||
| TARANTOOL_SERVER_USER: root | |||
| TARANTOOL_SERVER_GROUP: root | |||
| TARANTOOL_VERSION: "2.11.2-centos7" | |||
There was a problem hiding this comment.
why didn't you delete this job? It's duplicate as a part of matrix tests
There was a problem hiding this comment.
I'v removed TrantoolCintainer classes from integration profile
There was a problem hiding this comment.
Got it. Then rename jobs, it's confusing because matrix tests are also integration tests
There was a problem hiding this comment.
tests-tarantool-container
tests-cartridge-container
tests-ee
| "\" > container-tmp.lua &&" + | ||
| " tarantool container-tmp.lua"; |
There was a problem hiding this comment.
describe this in comments if you didn't
|
I haven't forgotten about:
Related issues:
Closes #109