WIP Fixes and refactoring before release #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akudiyar
suggested changes
May 16, 2022
| * @param dockerfile dockerfile for building custom tarantool image | ||
| */ | ||
| public TarantoolImageParams(String tag, File dockerfile) { |
There was a problem hiding this comment.
I'd rather leave both variants (String and File). Both are useful
| final File dockerfile; | ||
| try { | ||
| dockerfile = new File( | ||
| Objects.requireNonNull(TarantoolContainerImageHelper.class.getClassLoader().getResource( |
There was a problem hiding this comment.
A message can be added here, otherwise it will be an unreadable stacktrace.
| * | ||
| * @param imageParams parameters for building tarantool image | ||
| * @return image name | ||
| */ | ||
| static String getImage(TarantoolImageParams imageParams) { | ||
| final String tag = imageParams.getTag(); | ||
|
|
||
| if (StringUtils.isEmpty(tag)) { | ||
| if (tag.isEmpty()) { |
There was a problem hiding this comment.
Is tag really never null?
|
To speed up the release I've left only necessary changed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.