Skip to content

Use add exposed ports instead of set exposed ports #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Conversation

ArtDu
Copy link
Contributor

@ArtDu ArtDu commented Jun 15, 2023

It's needed when you want to use not only default ports. For example it's usefull when you use metrics for TarantoolContainer.

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

Closes #65

@ArtDu ArtDu force-pushed the fix_exposed_ports branch from 7e822a5 to 8751547 Compare June 15, 2023 10:53
It's needed when you want to use not only default ports.
For example it's usefull when you use metrics for TarantoolContainer.
@ArtDu ArtDu force-pushed the fix_exposed_ports branch from 8751547 to 481ebe4 Compare June 15, 2023 10:55
@ArtDu ArtDu marked this pull request as ready for review June 15, 2023 10:56
@ArtDu ArtDu requested a review from bitgorbovsky June 15, 2023 10:57
bitgorbovsky
bitgorbovsky previously approved these changes Jun 15, 2023
Co-authored-by: Dmitry Kasimovskiy <98410443+dkasimovskiy@users.noreply.github.com>
@ArtDu ArtDu merged commit 046335e into master Jun 16, 2023
@ArtDu ArtDu deleted the fix_exposed_ports branch June 16, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional ports mapping
3 participants