Skip to content

Make a separate step for building the cartridge #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

nickkkccc
Copy link
Contributor

@nickkkccc nickkkccc commented Oct 11, 2023

This solution is a trade-off between GH cache space occupied and test pass rate towards test pass rate.

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:
Closes #94.

@nickkkccc nickkkccc requested review from akudiyar and ArtDu October 11, 2023 08:36
@nickkkccc nickkkccc linked an issue Oct 11, 2023 that may be closed by this pull request
@nickkkccc nickkkccc self-assigned this Oct 11, 2023
@nickkkccc nickkkccc marked this pull request as draft October 11, 2023 08:51
@nickkkccc
Copy link
Contributor Author

This solution is a trade-off between GH cache space occupied and test pass rate towards test pass rate.

@nickkkccc nickkkccc marked this pull request as ready for review October 12, 2023 06:55
@dkasimovskiy dkasimovskiy merged commit 96d309d into master Oct 13, 2023
@dkasimovskiy dkasimovskiy deleted the gh-94 branch October 13, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make rock dependencies load at the build stage of a Docker image
3 participants