spell: turn on pre-commit auto spell checker #1184
Conversation
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
370cdba to
c04ce9f
Compare
dmyger
changed the title
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
2b4a206 to
59e26ec
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
3 times, most recently
from
b4547b7 to
20a96d7
Compare
| @@ -44,7 +46,7 @@ def skip_no_helpers(request: pytest.FixtureRequest, completion: Completion) -> N | |||
|
|
|||
|
|
|||
| def pytest_configure(config): | |||
| config.addinivalue_line( | |||
| config.addinivalue_line( # cSpell:words addinivalue | |||
There was a problem hiding this comment.
If it's possible I'd suggest to introduce separate project-words file for integration tests directory. All pytest identifiers that are currently in use could be listed there.
There was a problem hiding this comment.
My opinion is that lists of “bad” words are workaround, because they should not exist. The fact that now a list of words is made at the project level is because there are too many such words already found throughout the old code. Ideally, the names should immediately meet the requirements of the checker.
And such marks raise a “red” flag - that something needs to be done here with refactoring. The word list on other hand hides this problem.
There was a problem hiding this comment.
Well... I agree with statement that "mark is better than hide", but what is need to be done with "third-party" identifiers (pytest identifier in this particular case) considering that we are not able to change them?
There was a problem hiding this comment.
What exactly identifier do you mean?
There was a problem hiding this comment.
In the current code it used only once at test/integration/completion/conftest.py:49? So I don't see a problem add a single comment to ignore it spell-checker:ignore ...
There was a problem hiding this comment.
And according to you it raises a "red" flag and something needs to be done. But since it is third-party identifier we are not able to do "something" with it (except of stop using it, but that's not the option obviously). Considering this project-words file might hold only "bad" words that can't be fixed.
There was a problem hiding this comment.
Anyway it's just a subject to discuss. I've approved PR already.
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
20a96d7 to
707afff
Compare
Closes #TNTP-3105
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
707afff to
25a4d6e
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
25a4d6e to
89506dd
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
2 times, most recently
from
da4751e to
0e01c6d
Compare
Part of #TNTP-3105
Part of #TNTP-3105
Part of #TNTP-3105
Due to formatting changes, it triggers the linter's errors. FIXME: turn on the checking with the following PR. Part of #TNTP-3105
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
0e01c6d to
400e4db
Compare
Turning on automatic static code analyzer: check words misspell for code files.
Closes #TNTP-3105
Come with second part in #1185