spell: turn on pre-commit auto spell checker #1184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
370cdba to
c04ce9f
Compare
dmyger
changed the title
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
2b4a206 to
59e26ec
Compare
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
3 times, most recently
from
b4547b7 to
20a96d7
Compare
oleg-jukovec
approved these changes
Jul 17, 2025
elhimov
requested changes
Jul 22, 2025
| SKIP: golangci-lint-full | ||
| with: | ||
| extra_args: --all-files --from-ref=${{ env.BASE_BRANCH }} --to-ref=HEAD --hook-stage=manual | ||
| # - name: pre-commit checks (diff) |
| equalf | ||
| errf | ||
| etcd* | ||
| etcdserver |
There was a problem hiding this comment.
Looks unnecessary as previous entry matches it.
| tlsdialer | ||
| tmpl | ||
| tnt+ | ||
| tntp |
There was a problem hiding this comment.
Looks unnecessary as previous entry matches it.
| @@ -145,7 +145,7 @@ func startEtcd(t *testing.T, opts etcdOpts) integration.LazyCluster { | |||
| func etcdPut(t *testing.T, etcd *clientv3.Client, key, value string) { | |||
| t.Helper() | |||
| var ( | |||
| presp *clientv3.PutResponse | |||
| presp *clientv3.PutResponse // spell-checker:ignore presp | |||
There was a problem hiding this comment.
In 'cli/cluster/integration_test.go' the same identifier changed to pResp. Please consider single approach.
| @@ -273,10 +273,10 @@ func TestConnectEtcd(t *testing.T) { | |||
| etcdPut(t, etcd, "foo", "bar") | |||
|
|
|||
| ctx, cancel := context.WithTimeout(context.Background(), timeout) | |||
| gresp, err := etcd.Get(ctx, "foo") | |||
| resp, err := etcd.Get(ctx, "foo") | |||
There was a problem hiding this comment.
In 'cli/cluster/integration_test.go' the similar identifier presp changed to pResp. Please consider similar approach here.
| @@ -502,6 +502,7 @@ func (publisher EtcdAllDataPublisher) Publish(revision int64, data []byte) error | |||
| txn = txn.If(cmps...) | |||
| } | |||
|
|
|||
| // spell-checker:ignore tresp | |||
There was a problem hiding this comment.
In 'cli/cluster/integration_test.go' the similar identifier presp changed to pResp. Please consider similar approach here.
| @@ -849,12 +850,12 @@ func СonnectEtcdUriOpts( | |||
| func DoOnStorage(connOpts ConnectOpts, opts libconnect.UriOpts, | |||
| tarantoolFunc func(tarantool.Connector) error, etcdFunc func(*clientv3.Client) error, | |||
| ) error { | |||
| etcdcli, errEtcd := СonnectEtcdUriOpts(opts, connOpts) | |||
| etcdcli, errEtcd := ConnectEtcdUriOpts(opts, connOpts) | |||
There was a problem hiding this comment.
So it turns out that we had public identifier with cyrillic symbol. Nice catch! )
| if errEtcd == nil { | ||
| return etcdFunc(etcdcli) | ||
| } | ||
|
|
||
| conn, errTarantool := СonnectTarantool(opts, connOpts) | ||
| conn, errTarantool := ConnectTarantool(opts, connOpts) |
| @@ -155,7 +155,7 @@ def test_promote_cconfig_failovers( | |||
| "manual-failover-2", | |||
| "election-failover-1", | |||
| "election-failover-2", | |||
| "eleciton-failover-3", | |||
| "eleciton-failover-3", # spell-checker:disable-line | |||
There was a problem hiding this comment.
Suggested change
| "eleciton-failover-3", # spell-checker:disable-line | |
| "election-failover-3", |
| @@ -44,7 +46,7 @@ def skip_no_helpers(request: pytest.FixtureRequest, completion: Completion) -> N | |||
|
|
|||
|
|
|||
| def pytest_configure(config): | |||
| config.addinivalue_line( | |||
| config.addinivalue_line( # cSpell:words addinivalue | |||
There was a problem hiding this comment.
If it's possible I'd suggest to introduce separate project-words file for integration tests directory. All pytest identifiers that are currently in use could be listed there.
Closes #TNTP-3105
Part of #TNTP-3105
Part of #TNTP-3105
Part of #TNTP-3105
Due to formatting changes, it triggers the linter's errors. FIXME: turn on the checking with the following PR. Part of #TNTP-3105
dmyger
force-pushed
the
dmyger/tntp-3105_turn_on_spell_checker_for_code
branch
from
20a96d7 to
707afff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning on automatic static code analyzer: check words misspell for code files.
Closes #TNTP-3105
Come with second part in #1185