Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicaset: add bootstrap #885

Merged
merged 3 commits into from
Jul 16, 2024
Merged

replicaset: add bootstrap #885

merged 3 commits into from
Jul 16, 2024

Conversation

psergee
Copy link
Collaborator

@psergee psergee commented Jun 26, 2024

Title: tt replicaset bootstrap bootstraps a Cartridge app or an instance

This patch adds new subcommand for the replicaset module.
tt replicaset bootstrap [flags] <APP_NAME|APP_NAME:INSTANCE_NAME> bootstraps a Cartridge cluster
or an instance.

The command combines two old cartridge-cli commands: setup and join.
Examples:

tt replicaset bootstrap cartridge_app bootstraps the cluster from the default
config file ("replicasets.yml" in the app directory), the file can be specified with --file option.

tt replicaset bootstrap --bootstrap-vshard cartridge_app bootstraps the cluster and vshard.

tt replicaset bootstrap --replicaset replicaset cartridge_app:inst joins the instance "inst" to the replicaset "replicaset".

Part of #316

Part of #316

@TarantoolBot document
Title: `tt replicaset bootstrap` bootstraps a Cartridge app or an instance

This patch adds new subcommand for the replicaset module.
`tt replicaset bootstrap [flags] <APP_NAME|APP_NAME:INSTANCE_NAME>` bootstraps a Cartridge cluster
or an instance.

The command combines two old cartridge-cli commands: `setup` and `join`.
Examples:

`tt replicaset bootstrap cartridge_app` bootstraps the cluster from the default
config file ("replicasets.yml" in the app directory), the file can be specified with `--file` option.

`tt replicaset bootstrap --bootstrap-vshard cartridge_app` bootstraps the cluster and vshard.

`tt replicaset bootstrap --replicaset replicaset cartridge_app:inst` joins the instance "inst" to the replicaset "replicaset".
@psergee psergee marked this pull request as ready for review June 28, 2024 11:16
@psergee psergee added the full-ci Enables full ci tests label Jun 28, 2024
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

I'm actually not sure if the command makes any sense in context of centralized config? It could try to start a clean instance.

Copy link
Contributor

@better0fdead better0fdead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thx for patch!

@psergee psergee merged commit 8b5a6f3 into master Jul 16, 2024
44 checks passed
@psergee psergee deleted the askalt/gh-316-bootstrap branch July 16, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants