Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to choose where to start rebalancer, via a config option #278

Closed
Gerold103 opened this issue May 13, 2021 · 3 comments
Closed

Allow to choose where to start rebalancer, via a config option #278

Gerold103 opened this issue May 13, 2021 · 3 comments
Assignees
Milestone

Comments

@Gerold103
Copy link
Collaborator

Otherwise it is hard to find it to read the logs.

@sharonovd
Copy link

I'd prefer to get this info from vshard.cfg more easily. Auto-choose is better than manual selection as long as I am able to quickly navigate to the node.

@sharonovd
Copy link

sharonovd commented May 13, 2021

E. g.

> vshard.locate_rebalancer()
 - 192.168.11.15:3301

@kyukhin kyukhin added the teamS Scaling label Jun 11, 2021
@kyukhin kyukhin added this to the wishlist milestone Aug 19, 2021
@Gerold103 Gerold103 self-assigned this Aug 15, 2023
@Gerold103 Gerold103 modified the milestones: wishlist, 0.2 Aug 15, 2023
Gerold103 added a commit that referenced this issue Aug 17, 2023
Currently people struggle to find the rebalancer location because
it is unclear where it is spawned automatically (on the master
with minimal uuid).

The patch allows to choose in the configuration where the
rebalancer should work and whether it should work at all.

Closes #278

@TarantoolBot document
Title: vshard: cfg to choose rebalancer mode and location

There are 2 new config options:

- Root option 'rebalancer_mode'. It can have one of the following
  values:
  - 'auto' - works like now. The rebalancer is selected as the
  master with the minimal UUID;
  - 'off' - rebalancer won't be active at all;
  - 'manual' - need to manually mark the node where the rebalancer
  should be spawned. The selection happens in the config.

  Default is 'auto'.

- Instance option 'rebalancer'. It can be true or false. At most
  one instance in the config can have it set to true. If the
  rebalancer mode is 'manual' and none of the instances have this
  flag true, then the rebalancer won't be started anywhere. This
  option is ignored when the mode is not 'manual'. Default is
  false.
Gerold103 added a commit that referenced this issue Aug 18, 2023
Currently people struggle to find the rebalancer location because
it is unclear where it is spawned automatically (on the master
with minimal uuid).

The patch allows to choose in the configuration where the
rebalancer should work and whether it should work at all.

Closes #278

@TarantoolBot document
Title: vshard: cfg to choose rebalancer mode and location

There are 2 new config options:

- Root option 'rebalancer_mode'. It can have one of the following
  values:
  - 'auto' - works like now. The rebalancer is selected as the
  master with the minimal UUID;
  - 'off' - rebalancer won't be active at all;
  - 'manual' - need to manually mark the node where the rebalancer
  should be spawned. The selection happens in the config.

  Default is 'auto'.

- Instance option 'rebalancer'. It can be true or false. At most
  one instance in the config can have it set to true. If the
  rebalancer mode is 'manual' and none of the instances have this
  flag true, then the rebalancer won't be started anywhere. This
  option is ignored when the mode is not 'manual'. Default is
  false.
@Gerold103
Copy link
Collaborator Author

Done in d624973 and 9fda354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants