-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot reload is broken if name is key #464
Labels
bug
Something isn't working
Comments
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 29, 2023
Currently hot reload failes, when named identification is used. It is cause by the fact, that we still pass uuid in storage.cfg during reload. Let's pass id instead of UUID. It's either uuid or name, depeding on identification_mode. If reload is done from the old version, where no replica.id exists, we fall back to replica.uuid. Closes tarantool#464 NO_DOC=bugfix
Serpentian
added a commit
to Serpentian/vshard
that referenced
this issue
Dec 29, 2023
Currently hot reload failes, when named identification is used. It is cause by the fact, that we still pass uuid in storage.cfg during reload. Let's pass id instead of UUID. It's either uuid or name, depending on identification_mode. If reload is done from the old version, where no replica.id exists, we fall back to replica.uuid. Closes tarantool#464 NO_DOC=bugfix
Gerold103
pushed a commit
that referenced
this issue
Jan 10, 2024
Currently hot reload failes, when named identification is used. It is cause by the fact, that we still pass uuid in storage.cfg during reload. Let's pass id instead of UUID. It's either uuid or name, depending on identification_mode. If reload is done from the old version, where no replica.id exists, we fall back to replica.uuid. Closes #464 NO_DOC=bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tarantool Enterprise 3.0.0-0-gf58f7d82a-r23-gc64
vshard 0.1.25
Code hot reload fails in case
identification_mode = 'name_as_key'
is used.Reproducer (no UUID):
main utils.c:679 E> LuajitError: .rocks/share/tarantool/vshard/storage/init.lua:3733: .rocks/share/tarantool/vshard/storage/init.lua:3582: Usage: cfg(configuration, this_replica_id)
Reproducer (with UUID):
The reason is likely to be this line of code
vshard/vshard/storage/init.lua
Line 4039 in bc84c65
which always uses uuid as key.
The text was updated successfully, but these errors were encountered: