Support Tarantool 3.0 #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerold103
force-pushed
the
gerold103/support-3.0
branch
3 times, most recently
from
62929f0
to
0ad20af
Compare
olegrok
approved these changes
Mar 30, 2023
| return info.replicaset.uuid | ||
| end | ||
| else | ||
| replicaset_uuid= function(info) |
This file will be changed in a next commit. Checkpatch is complaining if the new lines have tabs. Need to convert the entire file to make it consistent. NO_DOC=refactoring
The newest Tarantool release will make several breaking changes.
The one concerning vshard - box.info.cluster changes its meaning.
This patch introduces a function for getting replicaset UUID not
depending on core Tarantool version.
Worth mentioning that Server:replicaset_uuid() workarounds this
issue on its own intentionally, without vshard.util. This is
because luatest shouldn't depend on vshard.
One test is still failing - upgrade.test.lua. It fails because
calls vshard.storage.cfg{} on 3.0 before upgrade. Non-first cfg
won't work on 3.0 because it uses box.info.cluster.uuid to check
if it matches UUID in the config. This can't be fixed as the old
code is already released years ago.
The test itself can be fixed, but it needs a commit to checkout to
upgrade from it. This commit is the first one supporting 3.0. It
means the test can only be fixed as a follow-up commit.
Another reload/upgrade test is reload_evolution/storage.test.lua.
It still works because doesn't try to call vshard.storage.cfg{}
until reload happens. Lets keep it while it is working fine.
Closes #402
NO_DOC=bugfix
The test tried to call vshard.storage.cfg{} second time on 3.0
using an old vshard version. It won't work because the old
non-first cfg tried to compare box.info.cluster.uuid with the
replicaset UUID in the config. But box.info.cluster.uuid is nil in
3.0. It was moved to box.info.replicaset.uuid.
The patch makes the upgrade test use the first commit compatible
with 3.0 as the basic version, if the Tarantool executable is 3.0.
Note that on versions < 3.0 the vshard upgrade still works fine,
hence on old executables the basic version is kept as is.
Follow up #402
NO_DOC=test
Gerold103
force-pushed
the
gerold103/support-3.0
branch
from
0ad20af
to
a2a9e87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not released yet and not even pushed to master branch. But vshard has to be ready in advance to make the integration tests pass. For trying 3.0 yourself use tarantool/tarantool#8289.