storage: fix local_call not finding C stored procedures #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serpentian
force-pushed
the
gh-436-local-call
branch
2 times, most recently
from
8e4d403
to
f6d7f61
Compare
Serpentian
force-pushed
the
gh-436-local-call
branch
from
f6d7f61
to
7896de9
Compare
Serpentian
force-pushed
the
gh-436-local-call
branch
from
7896de9
to
8cdac9d
Compare
Gerold103
reviewed
Nov 24, 2023
Currently, if function was created as C stored procedure or as Lua persistent function (with body argument) via box.schema.func.create, all types of router.call and router.map_callrw cannot find it and return `Procedure 'name' is not defined` error. This is cased by the fact that both of these function use local_call, which invokes net_box.self.call. It didn't work with these type of functions before Tarantool 3.0.0-beta1-18. Let's use box.func, where it's needed instead of net_box.self.call in local_call. Closes tarantool#436 NO_DOC=bugfix
Serpentian
force-pushed
the
gh-436-local-call
branch
from
8cdac9d
to
0c1346b
Compare
Gerold103
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if function was created as C stored procedure or as Lua
persistent function (with body argument) via box.schema.func.create,
all types of router.call and router.map_callrw cannot find it and
return
Procedure 'name' is not definederror.This is cased by the fact that both of these function use local_call,
which invokes net_box.self.call. It didn't work with these type of
functions before Tarantool 3.0.0-beta1-18. Let's use box.func, where
it's needed instead of net_box.self.call in local_call.
Closes #436
NO_DOC=bugfix