Fix NaNs for cool atmospheres with H2+BF and H-FF opacities enabled. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvshields
requested review from
andrewfullard,
DeerWhale and
Knights-Templars
|
Given the non-physical nature of this change, I think raising a warning would be appropriate |
I've added a logger warning for this. |
DeerWhale
approved these changes
Oct 14, 2024
DeerWhale
approved these changes
Oct 14, 2024
andrewfullard
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our H2+ bound-free opacity table has a lower temperature bound of 3150 K, a temperature that is reasonably achievable in the outermost layers of cool stellar atmospheres. Scipy's LinearNDInterpolator defaults to nan, outside of the convex hull that it spans, which propagates to all of our opacities, and in turn to all of the fluxes. This PR changes that behavior to just assume that H2+ BF opacity does not contribute at these low temperatures, which isn't exactly physical but is better than the previous behavior of just not being able to run cool simulations with this opacity source turned on.
Also applies the same patch to H- FF opacity.