Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pytest version #1185

Merged
merged 7 commits into from
Jun 12, 2020
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 11, 2020

Description

  • Unpinned pytest from tardis_env3.yml.
  • Installing pytest-azurepiepelines from PyPI instead of GitHub.
  • Using non boolean skip condition in integration test.
  • Using pytestconfig instead of pytest.config.

Motivation and Context

@jaladh-singhal reported tests stopped working on Azure. Maybe it's time to move to pytest 5.

pytest.config is deprecated (see links below). Instead we are using pytestconfig and non-boolean skip conditions. Maybe we can switch to the recommended request fixture in a future PR.

See also:

How Has This Been Tested?

All tests passes on Azure.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #1185 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1185   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          89       89           
  Lines        5551     5551           
=======================================
  Hits         4282     4282           
  Misses       1269     1269           
Impacted Files Coverage Δ
tardis/montecarlo/tests/test_packet_source.py 86.36% <100.00%> (ø)
tardis/plasma/tests/test_complete_plasmas.py 97.77% <100.00%> (ø)
tardis/tests/integration_tests/test_integration.py 26.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6056f3b...fd68f17. Read the comment docs.

Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @epassaro for fixing this.

tardis_env3.yml Outdated
@@ -52,7 +52,7 @@ dependencies:

#Test/Coverage requirements
- git-lfs
- pytest=4
- pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pin this.

@wkerzendorf wkerzendorf merged commit e5e2919 into tardis-sn:master Jun 12, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Unpin pytest version from environment file

* Fix integration tests skip condition

* Revert "Fix integration tests skip condition"

This reverts commit bb170bf.

* Trying new solution

* Using `pytestconfig`

* Using `pytestconfig` (2)

* Pin pytest to 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants