-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pytest version #1185
Upgrade pytest version #1185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1185 +/- ##
=======================================
Coverage 77.13% 77.13%
=======================================
Files 89 89
Lines 5551 5551
=======================================
Hits 4282 4282
Misses 1269 1269
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @epassaro for fixing this.
tardis_env3.yml
Outdated
@@ -52,7 +52,7 @@ dependencies: | |||
|
|||
#Test/Coverage requirements | |||
- git-lfs | |||
- pytest=4 | |||
- pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please pin this.
* Unpin pytest version from environment file * Fix integration tests skip condition * Revert "Fix integration tests skip condition" This reverts commit bb170bf. * Trying new solution * Using `pytestconfig` * Using `pytestconfig` (2) * Pin pytest to 5
Description
pytest
fromtardis_env3.yml
.pytest-azurepiepelines
from PyPI instead of GitHub.pytestconfig
instead ofpytest.config
.Motivation and Context
@jaladh-singhal reported tests stopped working on Azure. Maybe it's time to move to pytest 5.
pytest.config
is deprecated (see links below). Instead we are usingpytestconfig
and non-boolean skip conditions. Maybe we can switch to the recommendedrequest
fixture in a future PR.See also:
How Has This Been Tested?
All tests passes on Azure.
Screenshots (if appropriate):
Types of changes
Checklist: