Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed latex strings to raw strings #1283

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

Ak0303
Copy link
Contributor

@Ak0303 Ak0303 commented Aug 21, 2020

Description

I've changed all the latex strings to raw strings !!

Motivation and Context

#1206

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #1283 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1283   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files          41       41           
  Lines        3428     3428           
=======================================
  Hits         2762     2762           
  Misses        666      666           
Impacted Files Coverage Δ
tardis/plasma/properties/atomic.py 87.75% <100.00%> (ø)
tardis/plasma/properties/continuum_processes.py 41.66% <100.00%> (ø)
tardis/plasma/properties/general.py 98.38% <100.00%> (ø)
tardis/plasma/properties/ion_population.py 85.71% <100.00%> (ø)
tardis/plasma/properties/j_blues.py 87.50% <100.00%> (ø)
tardis/plasma/properties/level_population.py 100.00% <100.00%> (ø)
tardis/plasma/properties/partition_function.py 91.47% <100.00%> (ø)
tardis/plasma/properties/plasma_input.py 100.00% <100.00%> (ø)
tardis/plasma/properties/radiative_properties.py 81.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94f292...f00f1ae. Read the comment docs.

@jaladh-singhal
Copy link
Member

Thanks for this PR @Ak0303 - we'll soon review it and let you know if it requires any edits! Keep contributing 🎉

Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified yourself that these changes work? Can you put in some screenshots of all of the rendered LaTeX?

Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently every change looks fine to me!

@Ak0303 can you still cross-check if your changes are rendered correctly (like @Rodot- suggested) by rendering each class property you changed (latex_name or latex_formula) as Latex in Jupyter notebook. E.g. for Levels class in tardis/plasma/properties/atomic.py, it'll look like:

import tardis
from IPython.display import Math, display
for ln in tardis.plasma.properties.atomic.Levels.latex_name:
    display(Math(ln))

The output should be exact same for your modified code and current code at tardis.

@wkerzendorf wkerzendorf merged commit c2b8add into tardis-sn:master Oct 14, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants