-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed latex strings to raw strings #1283
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
=======================================
Coverage 80.57% 80.57%
=======================================
Files 41 41
Lines 3428 3428
=======================================
Hits 2762 2762
Misses 666 666
Continue to review full report at Codecov.
|
Thanks for this PR @Ak0303 - we'll soon review it and let you know if it requires any edits! Keep contributing 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you verified yourself that these changes work? Can you put in some screenshots of all of the rendered LaTeX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently every change looks fine to me!
@Ak0303 can you still cross-check if your changes are rendered correctly (like @Rodot- suggested) by rendering each class property you changed (latex_name
or latex_formula
) as Latex in Jupyter notebook. E.g. for Levels
class in tardis/plasma/properties/atomic.py
, it'll look like:
import tardis
from IPython.display import Math, display
for ln in tardis.plasma.properties.atomic.Levels.latex_name:
display(Math(ln))
The output should be exact same for your modified code and current code at tardis.
Description
I've changed all the latex strings to raw strings !!Motivation and Context
#1206How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: