Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pyne to 0.7.0 #1296

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Pin pyne to 0.7.0 #1296

merged 1 commit into from
Sep 9, 2020

Conversation

andrewfullard
Copy link
Contributor

Fixes showstopper installation issue caused by the change from pyne.data.QAWarning to pyne.utils.QAWarning

Description

Edited pyne module to be specifically 0.7.0 in the environment configuration yml file

Motivation and Context

Fixes installation crash caused by updates to pyne that we don't want to port

How Has This Been Tested?

Tested by installing the environment using this branch and then installing TARDIS using python setup.py develop

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

Fixes showstopper installation issue caused by the change from pyne.data.QAWarning to pyne.utils.QAWarning
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #1296 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1296   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files          41       41           
  Lines        3423     3423           
=======================================
  Hits         2757     2757           
  Misses        666      666           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8e4ba...c3eb8bf. Read the comment docs.

@wkerzendorf wkerzendorf requested a review from epassaro September 9, 2020 08:09
@wkerzendorf
Copy link
Member

@chvogl signed off on it.

@wkerzendorf wkerzendorf merged commit 862025e into tardis-sn:master Sep 9, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Fixes showstopper installation issue caused by the change from pyne.data.QAWarning to pyne.utils.QAWarning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants