Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helper scripts #1332

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Remove helper scripts #1332

merged 2 commits into from
Nov 3, 2020

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Oct 27, 2020

Description

Motivation and Context

Since the Azure pipelines do not rely anymore on bash helper scripts (currently we use templates to avoid code duplication) it's a good idea to remove these unused files.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1332   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          46       46           
  Lines        3799     3799           
=======================================
  Hits         3099     3099           
  Misses        700      700           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a443a9d...cd6a976. Read the comment docs.

Copy link
Contributor

@chvogl chvogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish all PRs were as easy to review as this one.

@wkerzendorf wkerzendorf merged commit ad9c840 into tardis-sn:master Nov 3, 2020
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Remove helper scripts

* remove old docs pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants