Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Quickstart Problem #1382

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

isaacgsmith
Copy link
Member

After merging PR #1379, the documentation did not build. This should fix that issue.

Description

I just changed the filepath in one line of quickstart.ipynb.

Motivation and Context

As mentioned, the documentation did not build after merging PR #1379 due to a faulty filepath.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1382 (3c2b83b) into master (1c706d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1382   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files          66       66           
  Lines        5097     5097           
=======================================
  Hits         3690     3690           
  Misses       1407     1407           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c706d5...3c2b83b. Read the comment docs.

@andrewfullard andrewfullard merged commit 162f280 into tardis-sn:master Dec 11, 2020
@isaacgsmith isaacgsmith mentioned this pull request Dec 14, 2020
7 tasks
@isaacgsmith isaacgsmith deleted the build_problem branch December 16, 2020 17:31
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants