Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests with --generate-reference flag #1399

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

epassaro
Copy link
Member

Description

  • Use to_hdf method with new overwrite=True when required.
  • Removed unnecessary if statement for old pytest versions.

Motivation and Context

Test failed with --generate-reference flag since #1366 was merged.

How Has This Been Tested?

  • Testing pipeline
  • Other (please describe)

$ pytest tardis --tardis-refdata=/path/to/refdata --generate-reference

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1399 (7ee2a08) into master (e8ef961) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1399   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files          67       67           
  Lines        5312     5312           
=======================================
  Hits         3721     3721           
  Misses       1591     1591           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ef961...7ee2a08. Read the comment docs.

@epassaro epassaro force-pushed the fix-generate-reference branch from 527ad71 to 7ee2a08 Compare December 28, 2020 17:42
@andrewfullard andrewfullard merged commit 9c5e24c into tardis-sn:master Jan 8, 2021
@epassaro epassaro mentioned this pull request Jan 21, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants