-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docstr-coverage workflow #1409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
=======================================
Coverage 71.16% 71.16%
=======================================
Files 67 67
Lines 5521 5521
=======================================
Hits 3929 3929
Misses 1592 1592 Continue to review full report at Codecov.
|
epassaro
force-pushed
the
docstr-coverage
branch
3 times, most recently
from
January 10, 2021 01:31
06313e2
to
9de1222
Compare
epassaro
force-pushed
the
docstr-coverage
branch
from
January 12, 2021 22:53
7bd2d9e
to
30231a3
Compare
minor changes run on commited files only run on commited files only (2) run on commited files only (3) run on commited files only (4) run on commited files only (5) [skip ci] fail if coverage is lower than previous one fix typo make job conditional make job conditional (2) test update job test update job (2) [skip-ci] test update job (3) [skip-ci] test update job (4) [skip-ci] test update job (5) [skip-ci] test update job (6) [skip-ci] test update job (7) [skip-ci] round value store commit sha [skip-ci] store commit sha (2) [skip-ci] try simpler approach [skip-ci] try simpler approach (2) [skip-ci] try simpler approach (3) [skip-ci] try simpler approach (4) [skip-ci] try simpler approach (5) [skip-ci] try simpler approach (6) [skip-ci] use docstr-coverage latest release
epassaro
force-pushed
the
docstr-coverage
branch
from
January 27, 2021 16:03
670a018
to
1650c06
Compare
andrewfullard
approved these changes
Jan 27, 2021
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* add docstr-coverage workflow minor changes run on commited files only run on commited files only (2) run on commited files only (3) run on commited files only (4) run on commited files only (5) [skip ci] fail if coverage is lower than previous one fix typo make job conditional make job conditional (2) test update job test update job (2) [skip-ci] test update job (3) [skip-ci] test update job (4) [skip-ci] test update job (5) [skip-ci] test update job (6) [skip-ci] test update job (7) [skip-ci] round value store commit sha [skip-ci] store commit sha (2) [skip-ci] try simpler approach [skip-ci] try simpler approach (2) [skip-ci] try simpler approach (3) [skip-ci] try simpler approach (4) [skip-ci] try simpler approach (5) [skip-ci] try simpler approach (6) [skip-ci] use docstr-coverage latest release * update .docstr.yaml * remove line (workflow will fail) * blame files on pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I used the docstr-coverage package to check the docstring coverage of TARDIS. This package is well maintained and offers an interesting number of options that can be declared on the
.docstr.yaml
file.To try these changes locally, first install
docstr-coverage
latest commit:and then run
docstr-coverage
ontardis
repository folder.To integrate this package with our continuous integration cycle, I wrote a simple GitHub workflow which runs
docstr-coverage
twice:pull_request
and set the coverage as futureTHRESHOLD
value.HEAD
of thepull_request
, failing if coverage is lower thanTHRESHOLD
(for example, after writing a new function, class or method without any docstring).BEFORE MERGE:
.docstring.yaml
.git checkout ${{ github.event.pull_request.head.sha }} -- .docstr.yaml
line. The workflow will fail after doing this because currently.docstr.yaml
does not exist onmaster
, but this is fine.Motivation and Context
We want to get some information about the status of TARDIS documentation coverage and integrate that on our CI cycle.
How Has This Been Tested?
New GitHub Action.
Screenshots (if appropriate):
Types of changes
Checklist: