Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to get rid of
PerformanceWarning: indexing past lexsort depth may impact performance
Description
I tried creating a new column of wavelengths with CGS units in a different way. This way was just a little bit faster and
also got rid of the
WARNING
. The results were the same as well.Using the new way, I got this:
Simulation finished in 20 iterations and took 35.58 s (base.py:381)
and using the previous way I got this:
Simulation finished in 20 iterations and took 35.70 s (base.py:381)
Motivation and Context
This got rid of the
PerformanceWarning: indexing past lexsort depth may impact performance
.How Has This Been Tested?
Using
python setup.py test
I got156 passed, 1254 skipped, 6 xpassed in 4.95s
The notebooks are working fine as well.
Screenshots:
Before
After
Types of changes
Checklist: