Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting rid of lexsort warning #1479

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Mar 14, 2021

This is an attempt to get rid of PerformanceWarning: indexing past lexsort depth may impact performance

Description

I tried creating a new column of wavelengths with CGS units in a different way. This way was just a little bit faster and
also got rid of the WARNING. The results were the same as well.
Using the new way, I got this:
Simulation finished in 20 iterations and took 35.58 s (base.py:381)

and using the previous way I got this:
Simulation finished in 20 iterations and took 35.70 s (base.py:381)

Motivation and Context

This got rid of the PerformanceWarning: indexing past lexsort depth may impact performance.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Using python setup.py test I got 156 passed, 1254 skipped, 6 xpassed in 4.95s
The notebooks are working fine as well.

Screenshots:

Before
image
After
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@atharva-2001
Copy link
Member Author

@wkerzendorf would you mind reviewing it, please?

@atharva-2001 atharva-2001 mentioned this pull request Mar 14, 2021
12 tasks
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #1479 (1dbaf59) into master (9497250) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1479   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files          67       67           
  Lines        5523     5523           
=======================================
  Hits         3929     3929           
  Misses       1594     1594           
Impacted Files Coverage Δ
tardis/tardis/io/atom_data/base.py 91.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9497250...7da9a68. Read the comment docs.

@andrewfullard andrewfullard merged commit 9609cd2 into tardis-sn:master Apr 5, 2021
atharva-2001 added a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants