Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collisional ionization #1509

Merged
merged 7 commits into from
Mar 24, 2021
Merged

Conversation

chvogl
Copy link
Contributor

@chvogl chvogl commented Mar 23, 2021

This PR will add collisional ionization to the macro atom scheme.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@chvogl chvogl requested review from afloers and wkerzendorf March 23, 2021 20:25
@chvogl chvogl marked this pull request as draft March 23, 2021 20:26
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1509 (3b1f78a) into master (f545ede) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 3b1f78a differs from pull request most recent head bef53b6. Consider uploading reports for the commit bef53b6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
- Coverage   68.12%   67.94%   -0.19%     
==========================================
  Files          68       68              
  Lines        6040     6070      +30     
==========================================
+ Hits         4115     4124       +9     
- Misses       1925     1946      +21     
Impacted Files Coverage Δ
...is/tardis/plasma/properties/continuum_processes.py 38.48% <0.00%> (-0.73%) ⬇️
...s/tardis/plasma/properties/property_collections.py 100.00% <0.00%> (ø)
...rdis/plasma/properties/transition_probabilities.py 32.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f545ede...bef53b6. Read the comment docs.

@chvogl chvogl marked this pull request as ready for review March 24, 2021 14:03
@chvogl chvogl requested a review from andrewfullard March 24, 2021 14:04
@wkerzendorf wkerzendorf merged commit 3534d39 into tardis-sn:master Mar 24, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Add collisional recombination rate coefficient

* Add raw collisional ionization transition probabilities

* Fix photoionization transition probability

* Rename cumtrapz

* Rename variables for clarity

* Add missing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants