Replacing the contents of the news section with TARDIS twitter feed #1555

atharva-2001 · 2021-04-26T15:28:32Z

Fixes #1545

Description

The news section in the documentation is pretty outdated, this PR replaces its contents with a Twitter Timeline Widget.
Uses JS to customize the layout of the widget as mentioned here.
Changes the font of the News title

Motivation and context

Fixes #1545
See also: #1743

How has this been tested?

Testing pipeline.
Other.

This is working correctly in my documentation.

Examples

Before:

After:

Displays a message it not loaded:

Type of change

Bug fix.
New feature.
Breaking change.
None of the above.

Checklist

My change requires a change to the documentation.
- I have updated the documentation accordingly.
- (optional) I have built the documentation on my fork following the instructions.
I have assigned and requested two reviewers for this pull request.

andrewfullard · 2021-04-26T15:33:05Z

I see this on Firefox

codecov · 2021-04-26T15:38:26Z

Codecov Report

Merging #1555 (c08b553) into master (7eca324) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c08b553 differs from pull request most recent head 8455a39. Consider uploading reports for the commit 8455a39 to get more accurate results

@@            Coverage Diff             @@
##           master    #1555      +/-   ##
==========================================
- Coverage   67.20%   67.20%   -0.01%     
==========================================
  Files          73       73              
  Lines        6147     6150       +3     
==========================================
+ Hits         4131     4133       +2     
- Misses       2016     2017       +1

Impacted Files	Coverage Δ
...dis/montecarlo/montecarlo_numba/numba_interface.py	`49.62% <0.00%> (-0.38%)`	⬇️
tardis/tardis/montecarlo/montecarlo_numba/base.py	`29.62% <0.00%> (ø)`
...rdis/montecarlo/montecarlo_numba/tests/conftest.py	`91.11% <0.00%> (ø)`
...dis/montecarlo/montecarlo_numba/tests/test_base.py	`100.00% <0.00%> (ø)`
tardis/tardis/montecarlo/base.py	`88.64% <0.00%> (+0.06%)`	⬆️
tardis/tardis/montecarlo/packet_source.py	`97.29% <0.00%> (+0.07%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eca324...8455a39. Read the comment docs.

atharva-2001 · 2021-04-26T15:47:20Z

I too see it at first, but it is replaced quickly by the widget, even in firefox. Is it persistent in your case?

andrewfullard · 2021-04-26T15:58:40Z

The link persists for me. This happens in incognito mode, if I refresh the page, if I clear the page cache, and if I disable plugins.

Works for me in MS Edge

The bug happens in Firefox 88.0 Windows 10

atharva-2001 · 2021-04-26T16:19:29Z

Ah, I'm sorry, I got it now. I was able to reproduce it in incognito mode in Firefox. It seems Firefox blocks some of the resources that are required to produce the widget.
I was able to see the widget in incognito mode after disabling the tracking protection by clicking the shield icon on the top left corner.

Does doing this fix it for you?
Reference:
https://stackoverflow.com/questions/39317653/twitter-widgets-not-working-on-firefox-private-browser
https://twittercommunity.com/t/help-embedded-twitter-widget-not-working-in-latest-firefox/57828/4

andrewfullard · 2021-04-26T20:09:11Z

Yes, works for me. Unfortunate, but I'm not sure there's anything we can do about it?

atharva-2001 · 2021-04-27T17:51:17Z

How about displaying a message saying something like "you need to disable tracking protection to see the widget"? I am not sure how that can be done at the moment, though.

This might be useful to us:
https://stackoverflow.com/a/35070265/11974464
https://stackoverflow.com/questions/34294989/impossible-to-use-a-twitter-timeline-in-firefox

atharva-2001 · 2021-04-29T12:48:52Z

@andrewfullard I wrote some code to check if the widget is not loaded. If it detects this, it shows a message:

Please check it here.
It is working in firefox for me. Could you please tell me if it works for you too?

jaladh-singhal

This is an excellent addition. Thank you for doing the extra effort to customize the styles and for handling the JS-disabled issue.

Once you address my comments, it's ready to be merged.

docs/index.rst

jaladh-singhal · 2021-05-17T11:42:08Z

docs/news.rst

+        jQuery('.twitter-block').find('.twitter-timeline').contents().find('.timeline-Header-title.u-inlineBlock').children().css('font-size', '18px');
+        jQuery('.twitter-block').find('.twitter-timeline').contents().find('.timeline-Tweet-text').css({
+            'font-size': '16px',
+            'font': 'Lato,proxima-nova,Helvetica Neue,Arial,sans-serif;',


It will be 'font-family': 'Lato,proxima-nova,Helvetica Neue,Arial,sans-serif', instead - that's why fonts didn't appear to be changed.

docs/news.rst

atharva-2001 · 2021-05-18T12:27:05Z

Thank you for reviewing it! I will get it done as soon as possible.

atharva-2001 · 2021-05-23T10:42:21Z

@jaladh-singhal
I am terribly sorry for such a late response. Could you please check it now?

jaladh-singhal

Thanks for changing jquery to vanilla JS - there's one small thing I've commented.

Also, I'm not able to see doc preview - link shows 404, can you build the docs by pushing your commit prefixed with [build docs]?

jaladh-singhal · 2021-05-25T14:24:37Z

docs/news.rst

+          var index;
+          for (let index = 0; index < tweetTextList.length; index++) {
+            tweetTextList[index].style.fontSize = "16px";
+            tweetTextList[index].style.font = "Lato,proxima-nova,Helvetica Neue,Arial,sans-serif;";


Most probably it won't work - have you checked the font being used by web inspector on built webpage?

You should instead do this (read here]:

Suggested change

tweetTextList[index].style.font = "Lato,proxima-nova,Helvetica Neue,Arial,sans-serif;";

tweetTextList[index].style.fontFamily = "Lato, proxima-nova, Helvetica Neue, Arial, sans-serif";

Oh, my bad, I fixed it now. Thanks again!
Could you please check this link to view the documentation?

jaladh-singhal · 2021-06-02T16:40:35Z

@atharva-2001 the font type gets changed - thanks! But there are 2 scrollbars in right on embedded twitter feed - I'm not sure why the outermost container has the scrollbar now, it wasn't there earlier.

jaladh-singhal

@atharva-2001 the font type gets changed - thanks! But there are 2 scrollbars in right on embedded twitter feed - I'm not sure why the outermost container has the scrollbar now, it wasn't there earlier.

There's this one last thing (I know it has stretched alot, I always point out something!) :)

atharva-2001 · 2021-06-04T07:23:39Z

I'm sorry for getting it done so late, my bad I couldn't see the two scrollbars problem
It's fixed now though.

…ardis-sn#1555) * Replacing the contents of the news section with TARDIS twitter feed * add css link * removing two scrollbars * [build docs]

atharva-2001 changed the title ~~adding tardis tweets to news feed~~ Replacing the contents of the news section with TARDIS twitter feed Apr 26, 2021

andrewfullard requested review from andrewfullard and jaladh-singhal April 26, 2021 15:33

andrewfullard added the documentation label Apr 26, 2021

atharva-2001 mentioned this pull request Apr 26, 2021

Twitter feed on docs page to replace News section #1545

Closed

andrewfullard approved these changes Apr 27, 2021

View reviewed changes

atharva-2001 requested a review from andrewfullard April 29, 2021 12:51

atharva-2001 force-pushed the news_feed branch from 7177257 to 820a25c Compare April 29, 2021 13:48

andrewfullard approved these changes Apr 29, 2021

View reviewed changes

jaladh-singhal requested changes May 17, 2021

View reviewed changes

atharva-2001 force-pushed the news_feed branch from 9ffa87b to f138ec9 Compare May 23, 2021 11:07

atharva-2001 requested a review from jaladh-singhal May 23, 2021 11:17

jaladh-singhal requested changes May 25, 2021

View reviewed changes

Replacing the contents of the news section with TARDIS twitter feed

da316d3

atharva-2001 force-pushed the news_feed branch from f138ec9 to da316d3 Compare May 25, 2021 16:16

add css link

c5f1afa

atharva-2001 requested a review from jaladh-singhal June 1, 2021 08:32

jaladh-singhal requested changes Jun 3, 2021

View reviewed changes

removing two scrollbars

ca4a805

[build docs]

8455a39

jaladh-singhal approved these changes Jun 4, 2021

View reviewed changes

jaladh-singhal merged commit 267906d into tardis-sn:master Jun 4, 2021

atharva-2001 mentioned this pull request Aug 18, 2021

Fix for Unresponsive Main Page due to Twitter Widget #1743

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replacing the contents of the news section with TARDIS twitter feed #1555

Replacing the contents of the news section with TARDIS twitter feed #1555

atharva-2001 commented Apr 26, 2021 •

edited

Loading

andrewfullard commented Apr 26, 2021

codecov bot commented Apr 26, 2021 •

edited

Loading

atharva-2001 commented Apr 26, 2021

andrewfullard commented Apr 26, 2021 •

edited

Loading

atharva-2001 commented Apr 26, 2021

andrewfullard commented Apr 26, 2021

atharva-2001 commented Apr 27, 2021

atharva-2001 commented Apr 29, 2021 •

edited

Loading

jaladh-singhal left a comment

jaladh-singhal May 17, 2021

atharva-2001 commented May 18, 2021

atharva-2001 commented May 23, 2021

jaladh-singhal left a comment •

edited

Loading

jaladh-singhal May 25, 2021

atharva-2001 May 25, 2021 •

edited

Loading

jaladh-singhal commented Jun 2, 2021

jaladh-singhal left a comment

atharva-2001 commented Jun 4, 2021

	tweetTextList[index].style.font = "Lato,proxima-nova,Helvetica Neue,Arial,sans-serif;";
	tweetTextList[index].style.fontFamily = "Lato, proxima-nova, Helvetica Neue, Arial, sans-serif";

Replacing the contents of the news section with TARDIS twitter feed #1555

Replacing the contents of the news section with TARDIS twitter feed #1555

Conversation

atharva-2001 commented Apr 26, 2021 • edited Loading

andrewfullard commented Apr 26, 2021

codecov bot commented Apr 26, 2021 • edited Loading

Codecov Report

atharva-2001 commented Apr 26, 2021

andrewfullard commented Apr 26, 2021 • edited Loading

atharva-2001 commented Apr 26, 2021

andrewfullard commented Apr 26, 2021

atharva-2001 commented Apr 27, 2021

atharva-2001 commented Apr 29, 2021 • edited Loading

jaladh-singhal left a comment

Choose a reason for hiding this comment

jaladh-singhal May 17, 2021

Choose a reason for hiding this comment

atharva-2001 commented May 18, 2021

atharva-2001 commented May 23, 2021

jaladh-singhal left a comment • edited Loading

Choose a reason for hiding this comment

jaladh-singhal May 25, 2021

Choose a reason for hiding this comment

atharva-2001 May 25, 2021 • edited Loading

Choose a reason for hiding this comment

jaladh-singhal commented Jun 2, 2021

jaladh-singhal left a comment

Choose a reason for hiding this comment

atharva-2001 commented Jun 4, 2021

atharva-2001 commented Apr 26, 2021 •

edited

Loading

codecov bot commented Apr 26, 2021 •

edited

Loading

andrewfullard commented Apr 26, 2021 •

edited

Loading

atharva-2001 commented Apr 29, 2021 •

edited

Loading

jaladh-singhal left a comment •

edited

Loading

atharva-2001 May 25, 2021 •

edited

Loading