-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better handling of pickle5 backport #1566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
==========================================
- Coverage 68.24% 67.05% -1.19%
==========================================
Files 73 73
Lines 6373 6144 -229
==========================================
- Hits 4349 4120 -229
Misses 2024 2024
Continue to review full report at Codecov.
|
2 tasks
andrewfullard
approved these changes
May 12, 2021
KevinCawley
reviewed
May 12, 2021
KevinCawley
approved these changes
May 12, 2021
9 tasks
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* better handling of pickle5 backport * blackify * move pickle5 to I/O section * remove duplicated dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pyne
macOS deprecation is still giving us problems (now with @KevinCawley and the numba integration pipeline). I don't think this patch is enough to fix our problems, but provides a better handling of the hack.Moved
pickle5
frompip
section of the environment file (solves Broken environment definition file #1564).Motivation and context
See #1535.
How has this been tested?
Examples
Type of change
Checklist