Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PR review checklist workflow #1588

Merged
merged 7 commits into from
Jun 1, 2021
Merged

Conversation

aribalam
Copy link
Contributor

Description

Fixes #1169.
Brought forward from #1192.
Added a workflow that creates a comment on the Pull Request whenever a review is requested. It mentions all the checks that need to be performed by the reviewers before approving/rejecting them.

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other. Locally tested by a test fork.

Examples

Screenshot below -

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #1588 (4130412) into master (e55f3e0) will not change coverage.
The diff coverage is n/a.

❗ Current head 4130412 differs from pull request most recent head 3d5dbaf. Consider uploading reports for the commit 3d5dbaf to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          73       73           
  Lines        6147     6147           
=======================================
  Hits         4131     4131           
  Misses       2016     2016           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55f3e0...3d5dbaf. Read the comment docs.

Copy link
Member

@wkerzendorf wkerzendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is nice- @marxwillia what do you think?

@epassaro epassaro self-requested a review June 1, 2021 21:22
@wkerzendorf wkerzendorf merged commit bb94f0e into tardis-sn:master Jun 1, 2021
@aribalam aribalam mentioned this pull request Jun 3, 2021
10 tasks
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* Add template PR review comment

* Update with correct checklist

* Indent correctly

* Use hyperlink in PR comment

Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com>

* changed event type and action

* corrected typos

* renamed file and workflow name

Co-authored-by: Arjun Savel <asavel@berkeley.edu>
Co-authored-by: Arjun Savel <35353555+arjunsavel@users.noreply.github.com>
Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PR review checklist
4 participants