-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PR review checklist workflow #1588
Conversation
Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1588 +/- ##
=======================================
Coverage 67.20% 67.20%
=======================================
Files 73 73
Lines 6147 6147
=======================================
Hits 4131 4131
Misses 2016 2016 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is nice- @marxwillia what do you think?
* Add template PR review comment * Update with correct checklist * Indent correctly * Use hyperlink in PR comment Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com> * changed event type and action * corrected typos * renamed file and workflow name Co-authored-by: Arjun Savel <asavel@berkeley.edu> Co-authored-by: Arjun Savel <35353555+arjunsavel@users.noreply.github.com> Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com>
Description
Fixes #1169.
Brought forward from #1192.
Added a workflow that creates a comment on the Pull Request whenever a review is requested. It mentions all the checks that need to be performed by the reviewers before approving/rejecting them.
Motivation and context
How has this been tested?
Examples
Screenshot below -
Type of change
Checklist