Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing inconsistencies for rst formatting in Docs (Second Iteration) #1590

Merged
merged 2 commits into from
May 31, 2021

Conversation

DhruvSondhi
Copy link
Contributor

@DhruvSondhi DhruvSondhi commented May 26, 2021

This PR aims to fix some of the inconsistencies are present in the current documentation.
Fixing this also removes some of the warnings that are present when building the documentation 😄

Description

Some of the changes include small whitespace, tabs & newline additions
Others includes removing the None keyword from .. code-block:: directives in update_refdata.rst, updating the underlines for some of the headings.

Motivation and context

This will fix some of the warnings that are present when building the documentation locally 😄

Documentation Preview : https://dhruvsondhi.github.io/tardis/branch/docs_formatting_v2/

How has this been tested?

  • Testing pipeline.
  • Other.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@DhruvSondhi DhruvSondhi force-pushed the docs_formatting_v2 branch from a4ffd03 to bed98dc Compare May 26, 2021 07:27
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #1590 (458ee36) into master (351cc8f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1590   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          73       73           
  Lines        6147     6147           
=======================================
  Hits         4131     4131           
  Misses       2016     2016           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351cc8f...458ee36. Read the comment docs.

@DhruvSondhi DhruvSondhi force-pushed the docs_formatting_v2 branch from 59cd92a to 458ee36 Compare May 27, 2021 05:35
Copy link
Contributor Author

@DhruvSondhi DhruvSondhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

Copy link
Member

@isaacgsmith isaacgsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jaladh-singhal jaladh-singhal merged commit 8fb804f into tardis-sn:master May 31, 2021
@DhruvSondhi DhruvSondhi deleted the docs_formatting_v2 branch June 2, 2021 04:56
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
tardis-sn#1590)

* Fixing inconsistencies for rst formatting

* Setting code-block lexer to none in update_refdata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants