-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing docstrings
& indentation related warnings for Sphinx
#1617
Fixing docstrings
& indentation related warnings for Sphinx
#1617
Conversation
Before a PR is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
=======================================
Coverage 67.20% 67.20%
=======================================
Files 73 73
Lines 6150 6150
=======================================
Hits 4133 4133
Misses 2017 2017
Continue to review full report at Codecov.
|
4aad62c
to
ec61e19
Compare
@@ -98,8 +98,8 @@ class Simulation(PlasmaStateStorerMixin, HDFWriterMixin): | |||
nthreads : int | |||
The number of threads to run montecarlo with | |||
|
|||
.. note:: TARDIS must be built with OpenMP support in order for | |||
`nthreads` to have effect. | |||
.. note:: TARDIS must be built with OpenMP support in order for ``nthreads`` to have effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we rewrite this now that we do not use OpenMP @andrewfullard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for this pull request. However, it should be changed. The note for that variable should be removed, assuming it is still used in the class.
55d6c5f
to
f45a518
Compare
f45a518
to
2fd375e
Compare
Before a pull request is accepted, it must meet the following criteria:
|
2fd375e
to
aa59a8c
Compare
This PR aims to fix all the warnings related to the docstring & indentations that are being generated when building the documentation.
Docstrings have been updated successfully.
Most of the indentation errors have been fixed.
Documentation Preview: https://dhruvsondhi.github.io/tardis/branch/fix_docstring_errors/index.html
Description
Some of the
docstring
had unexpected indentations & hence rose warnings whenever building the documentationA notable example can be seen here:
before --> Check here
after --> Check here
Some of the documentation pages had wrong directives for code blocks. Those have been taken care of in the Pull Request.
This removes these warnings & hence makes it easier to build the documentation
Motivation and context
Fixing Sphinx Warning will allow for better generation of the Documentation via Sphinx.
How has this been tested?
Type of change
Checklist