-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mailmap check workflow #1644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
- Coverage 67.70% 61.92% -5.79%
==========================================
Files 68 62 -6
Lines 6091 5702 -389
==========================================
- Hits 4124 3531 -593
- Misses 1967 2171 +204
Continue to review full report at Codecov.
|
Before a pull request is accepted, it must meet the following criteria:
|
@epassaro, could you please add my name too?
|
what's your preferred email? |
I'm sorry for the confusion, please add this email:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would then also include the ORCID check as well.
I don't see any problem to keep ORCiD optional. The only difference should be names in Zenodo will not appear with the green "ID" balloon. |
done |
* add mailmap check workflow * add another dhruv email to .mailmap * sort mailmap alphabetically * add atharva email adress * more mailmap fixes
Description
Checks if all committers in a PR are in the
.mailmap
(name and email).Sorted
.mailmap
alphabetically.Motivation and context
I'm not sure if this is a good workflow to merge, you decide.
Currently, the TARDIS policy is considering all committers as authors and order them by commit numbers plus other criteria. The new Zenodo metadata pipeline will not fail anymore when an author name is incomplete, or an author committed with different emails. In this case those authors/commits are just dropped and the pipeline keeps working the longest possible without human intervention.
Then, to not lose authors or commit contributions I wrote this pipeline that checks author name and email before merging a PR.
How has this been tested?
The new pipeline itself!
Examples
Type of change
Checklist