Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to environment #1652

Merged
merged 9 commits into from
Jun 16, 2021
Merged

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 15, 2021

Description

  • We agreed to pin Python minor version to have the same version in Linux and macOS independently of the conda dependency solving process. Currently it's 3.7 due to pyne holding back newer python releases #1537
  • Removed unused sphinxcontrib-tikz extension, not activated in conf.py.
  • Unpinned numba bugfix version. Do not pin the bugfix version unless it's really necessary.
  • Moved Jupyter to Visualization section since it's required for the new viz module.
  • Commented out pyside2 since Qt GUI is not used and soon to be deprecated. Also gave us problems recently, see Issue creating new TARDIS env (pyside2) #1608
  • Add previously removed tardisnuclear dependencies in a separate section. I removed them in the past because weren't used in TARDIS code, in the future please use a different section for packages that are not required by tardis package!.

Motivation and context

Regular env update. Also we had some other related files to mantain: the conda-forge package (requires moving to new package template first) and the numba pipeline (maintained by @KevinCawley). There's no nice way to keep dependency tracking in a single file, so let's keep the tardis_env3.yml file as tidy as possible.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1652 (90a5d22) into master (66b10ad) will not change coverage.
The diff coverage is n/a.

❗ Current head 90a5d22 differs from pull request most recent head d2711d0. Consider uploading reports for the commit d2711d0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1652   +/-   ##
=======================================
  Coverage   61.92%   61.92%           
=======================================
  Files          62       62           
  Lines        5702     5702           
=======================================
  Hits         3531     3531           
  Misses       2171     2171           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b10ad...d2711d0. Read the comment docs.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@andrewfullard andrewfullard merged commit 7a7d135 into tardis-sn:master Jun 16, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* pin python minor version

* remove unused sphinx extension

* minor changes

* do not pin numba bugfix ver

* move jupyter to viz section

* divide sections

* comment out qt gui dep

* add again nuclear deps in a separate section

* add comment [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants