-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to environment #1652
changes to environment #1652
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1652 +/- ##
=======================================
Coverage 61.92% 61.92%
=======================================
Files 62 62
Lines 5702 5702
=======================================
Hits 3531 3531
Misses 2171 2171 Continue to review full report at Codecov.
|
Before a pull request is accepted, it must meet the following criteria:
|
* pin python minor version * remove unused sphinx extension * minor changes * do not pin numba bugfix ver * move jupyter to viz section * divide sections * comment out qt gui dep * add again nuclear deps in a separate section * add comment [skip ci]
Description
sphinxcontrib-tikz
extension, not activated inconf.py
.pyside2
since Qt GUI is not used and soon to be deprecated. Also gave us problems recently, see Issue creating new TARDIS env (pyside2) #1608tardisnuclear
dependencies in a separate section. I removed them in the past because weren't used in TARDIS code, in the future please use a different section for packages that are not required bytardis
package!.Motivation and context
Regular env update. Also we had some other related files to mantain: the conda-forge package (requires moving to new package template first) and the numba pipeline (maintained by @KevinCawley). There's no nice way to keep dependency tracking in a single file, so let's keep the
tardis_env3.yml
file as tidy as possible.How has this been tested?
Examples
Type of change
Checklist