-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add refdata repo selection in template #1658
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1658 +/- ##
=======================================
Coverage 61.89% 61.89%
=======================================
Files 62 62
Lines 5732 5732
=======================================
Hits 3548 3548
Misses 2184 2184 Continue to review full report at Codecov.
|
/AzurePipelines run compare-refdata |
Azure Pipelines successfully started running 1 pipeline(s). |
Build succeeded 96b9375 |
edf8058
to
713866a
Compare
/AzurePipelines run compare-refdata |
Azure Pipelines successfully started running 1 pipeline(s). |
Build succeeded 52b3d7d |
/azp run compare-refdata |
Azure Pipelines successfully started running 1 pipeline(s). |
Build succeeded 42c698f |
trigger: | ||
tags: | ||
include: | ||
- '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compare reference data every time a new TARDIS release is made.
branches: | ||
include: | ||
- master | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not run monthly tests anymore.
@@ -38,26 +34,18 @@ jobs: | |||
steps: | |||
- template: templates/default.yml | |||
parameters: | |||
fetchRefdata: false # See the comment below. | |||
fetchRefdata: true | |||
refdataRepo: 'github' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compare-refdata
pipeline is simplified by using GitHub source instead of Azure (thanks to our new sponsor GitHub we have free LFS).
- bash: | | ||
cd $(refdata.dir) | ||
git remote add upstream https://tardis-sn@dev.azure.com/tardis-sn/TARDIS/_git/tardis-refdata | ||
git remote add upstream $(git remote get-url origin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, upstream is the same as origin.
- bash: | | ||
ssh azuredevops@opensupernova.org "mkdir -p /home/azuredevops/public_html/files/refdata-results/$(pr.number)" | ||
ssh azuredevops@opensupernova.org "mkdir -p /home/azuredevops/public_html/files/refdata-results/$(subfolder)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put everything under a subfolder: PR (by pr number), manual triggered builds and release builds.
Before a pull request is accepted, it must meet the following criteria:
|
* changes to pipeline template * changes to refdata pipeline * remove scheduled trigger, use tags instead * revert some changes to template * change param name * update update-refdata pipeline * specify refdata repo * simplify compare-refdata pipeline, use gh repo by default * remove debug prints * change docs
Description
tardis-refdata
repo source betweenazure
orgithub
.scheduled
trigger incompare-refdata
pipeline. Instead run when a newtag
is pushed (new release).compare-refdata
andupdate-refdata
pipelines by usinggithub
source.skipInstall
step totardisEnv
.Motivation and context
Trying to test new atomic data (#1668) realized the reference data mirror does not suit the use case of comparing PRs made to
tardis-refdata
(for exampleupstream/pr/46
). That happens because the mirror does not contain information about the PRs.Then I added a new parameter to the
default
template to select the source of reference data. Thecompare-refdata
andupdate-refdata
pipelines usegithub
source by default (thanks to new GH sponsorship we have free LFS quota). This solves the above described scenario, and simplifies the pipeline in many ways.How has this been tested?
compare-refdata
pipeline.Examples
Type of change
Checklist