Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare release pipeline for CalVer #1683

Merged
merged 6 commits into from
Jul 2, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jul 1, 2021

Description

Mark releases as full releases. Enable CalVer tag solving.

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #1683 (1f5c287) into master (01a3495) will not change coverage.
The diff coverage is n/a.

❗ Current head 1f5c287 differs from pull request most recent head a584c89. Consider uploading reports for the commit a584c89 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1683   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files          63       63           
  Lines        5792     5792           
=======================================
  Hits         3550     3550           
  Misses       2242     2242           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a3495...a584c89. Read the comment docs.

@jaladh-singhal jaladh-singhal force-pushed the master branch 2 times, most recently from 2907807 to d5ac38a Compare July 1, 2021 18:47
@epassaro epassaro changed the title disable pre-releases prepare release pipeline for CalVer Jul 1, 2021
@epassaro epassaro force-pushed the enable-full-releases branch from 24e2650 to 13362a0 Compare July 1, 2021 22:21
@epassaro epassaro force-pushed the enable-full-releases branch from 13362a0 to 465d987 Compare July 1, 2021 23:22
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@wkerzendorf wkerzendorf merged commit 58e4e79 into tardis-sn:master Jul 2, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
* disable pre-releases

* remove v from tags

* enable CalVer on setup.py

* use release- in tag

* fix typo

* remove fetch depth option from test pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants