Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Simulation & Montecarlo Logging Frameworks to tardis/io/logger folder #1684

Merged
merged 5 commits into from
Jul 12, 2021
Merged

Moved Simulation & Montecarlo Logging Frameworks to tardis/io/logger folder #1684

merged 5 commits into from
Jul 12, 2021

Conversation

DhruvSondhi
Copy link
Contributor

Moved the logging frameworks along with the tests to a new logger folder inside the tardis/io directory.

Description

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above. Restructure of the Logging Framework

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@DhruvSondhi DhruvSondhi requested review from Rodot-, wkerzendorf and andrewfullard and removed request for Rodot- and wkerzendorf July 2, 2021 06:59
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jul 2, 2021 •
edited
Loading

Codecov Report

Merging #1684 (4eb2a0d) into master (7994739) will increase coverage by 0.31%.
The diff coverage is n/a.

❗ Current head 4eb2a0d differs from pull request most recent head 9008e5b. Consider uploading reports for the commit 9008e5b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
+ Coverage   61.26%   61.58%   +0.31%     
==========================================
  Files          63       64       +1     
  Lines        5798     5859      +61     
==========================================
+ Hits         3552     3608      +56     
- Misses       2246     2251       +5
Impacted Files Coverage Δ
tardis/tardis/montecarlo/base.py 88.64% <0.00%> (ø)
tardis/tardis/util/colored_logger.py
...s/montecarlo/montecarlo_numba/montecarlo_logger.py
tardis/tardis/io/logger/logger.py 91.80% <0.00%> (ø)
tardis/tardis/io/logger/colored_logger.py 78.12% <0.00%> (ø)
tardis/tardis/io/logger/montecarlo_logger.py 59.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7994739...9008e5b. Read the comment docs.

@DhruvSondhi DhruvSondhi force-pushed the restructure_logging_framework branch from 32e2c07 to 0eb981f Compare July 6, 2021 04:53
@wkerzendorf
Copy link
Member

There is duplicate code in simulation_logger - please clean that up!

Rodot-
Rodot- requested changes Jul 6, 2021
View reviewed changes
tardis/io/logger/simulation_logger.py Outdated Show resolved Hide resolved
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@DhruvSondhi DhruvSondhi force-pushed the restructure_logging_framework branch from fce4aab to a240f15 Compare July 8, 2021 08:31
@DhruvSondhi DhruvSondhi requested a review from Rodot- July 9, 2021 13:36
@andrewfullard andrewfullard merged commit 1af3a40 into tardis-sn:master Jul 12, 2021
@DhruvSondhi DhruvSondhi deleted the restructure_logging_framework branch July 12, 2021 18:06
@DhruvSondhi DhruvSondhi mentioned this pull request Jul 17, 2021
Merged
10 tasks
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
@DhruvSondhi
Moved Simulation & Montecarlo Logging Frameworks to `tardis/io/logger…
bff3b79 
…` folder (tardis-sn#1684)

* Moved Logging Frameworks to tardis/io/logger folder

* Fixing some errors with the tests

* Changed simulation_logger.py to logger.py

* Changed implementation to target only TARDIS loggers
Removed list_of_filters to check the filters from the logger itself

* Removed list creation in logging_state & Moved in tardis_logger()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfullard andrewfullard andrewfullard approved these changes

@wkerzendorf wkerzendorf Awaiting requested review from wkerzendorf

@Rodot- Rodot- Awaiting requested review from Rodot-

Assignees
No one assigned
Labels
io logging restructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DhruvSondhi @tardis-bot @wkerzendorf @Rodot- @andrewfullard