-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed log_state
to log_level
for setting the logging level in the Logger
#1730
Renamed log_state
to log_level
for setting the logging level in the Logger
#1730
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 63 63
Lines 5852 5852
=======================================
Hits 3621 3621
Misses 2231 2231 Continue to review full report at Codecov.
|
e70e800
to
3a58fea
Compare
This PR aims to rename
log_state
tolog_level
for better understanding of the option available in therun_tardis()
function.Description
Renamed the
log_state
variable tolog_level
everywhere.log_level
makes more sense as through this variable we are setting the log level for theTARDIS
Logger. This allows for an intuitive understanding of the option available via therun_tardis()
function.Motivation and context
How has this been tested?
Type of change
Checklist