Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed log_state to log_level for setting the logging level in the Logger #1730

Merged

Conversation

DhruvSondhi
Copy link
Contributor

This PR aims to rename log_state to log_level for better understanding of the option available in the run_tardis() function.

Description
Renamed the log_state variable to log_level everywhere. log_level makes more sense as through this variable we are setting the log level for the TARDIS Logger. This allows for an intuitive understanding of the option available via the run_tardis() function.

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above. Renaming/Restructuring

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1730 (51b941a) into master (d3f13ed) will not change coverage.
The diff coverage is n/a.

❗ Current head 51b941a differs from pull request most recent head 3a58fea. Consider uploading reports for the commit 3a58fea to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1730   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files          63       63           
  Lines        5852     5852           
=======================================
  Hits         3621     3621           
  Misses       2231     2231           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f13ed...3a58fea. Read the comment docs.

@DhruvSondhi DhruvSondhi force-pushed the rename_logstate_to_loglevel branch from e70e800 to 3a58fea Compare July 17, 2021 15:00
@andrewfullard andrewfullard merged commit 2c47baa into tardis-sn:master Jul 20, 2021
@isaacgsmith isaacgsmith mentioned this pull request Jul 20, 2021
8 tasks
@DhruvSondhi DhruvSondhi deleted the rename_logstate_to_loglevel branch July 21, 2021 04:30
DhruvSondhi added a commit to DhruvSondhi/tardis that referenced this pull request Aug 1, 2021
DhruvSondhi added a commit to DhruvSondhi/tardis that referenced this pull request Aug 9, 2021
DhruvSondhi added a commit to DhruvSondhi/tardis that referenced this pull request Aug 9, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants