Renamed montecarlo_logger.py to montecarlo_tracking.py
#1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
==========================================
- Coverage 62.45% 61.88% -0.57%
==========================================
Files 64 63 -1
Lines 5985 5851 -134
==========================================
- Hits 3738 3621 -117
+ Misses 2247 2230 -17
Continue to review full report at Codecov.
|
DhruvSondhi
force-pushed
the
rename_to_tracking
branch
from
f45f2b5
to
10ae886
Compare
andrewfullard
approved these changes
Jul 20, 2021
DhruvSondhi
force-pushed
the
rename_to_tracking
branch
from
10ae886
to
ed0717f
Compare
DhruvSondhi
force-pushed
the
rename_to_tracking
branch
from
ed0717f
to
a56cd41
Compare
DhruvSondhi
added a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 1, 2021
…#1740) * Renamed montecarlo_logger to montecarlo_tracking * Changed the import to montecarlo_tracking * Renamed import as mc_logger to mc_tracker
DhruvSondhi
added a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 9, 2021
…#1740) * Renamed montecarlo_logger to montecarlo_tracking * Changed the import to montecarlo_tracking * Renamed import as mc_logger to mc_tracker
DhruvSondhi
added a commit
to DhruvSondhi/tardis
that referenced
this pull request
Aug 9, 2021
…#1740) * Renamed montecarlo_logger to montecarlo_tracking * Changed the import to montecarlo_tracking * Renamed import as mc_logger to mc_tracker
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
…#1740) * Renamed montecarlo_logger to montecarlo_tracking * Changed the import to montecarlo_tracking * Renamed import as mc_logger to mc_tracker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
monetcarlo_logger.pyhas been renamed tomontecarlo_tracking.py. The new name signifies the actual working of this module. We are tracking the packet properties thus the new name is apt.Description
This is currently only a File rename PR.
Motivation and context
Better explanation of what is happening inside the module. Though this does have a logging configuration, it is just to set it up to output to a file.
How has this been tested?
Examples
Type of change
Checklist