Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing import for binder #1808

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

isaacgsmith
Copy link
Member

Motivation and context

The way we imported scipy.sparse.linalg in tardis/montecarlo/montecarlo_numba/formal_integral.py caused errors in binder.

How has this been tested?

  • Testing pipeline.
  • Other.
    Tested on binder, see below.

Examples

https://hub.gke2.mybinder.org/user/smithis7-tardis-hsplhrfd/lab/tree/docs/quickstart/quickstart.ipynb

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

1 similar comment
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@isaacgsmith isaacgsmith changed the title Importing scipy.sparse.linalg Fixing import for binder Oct 4, 2021
@andrewfullard
Copy link
Contributor

Needs rebasing

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1808 (8dbb1df) into master (c1b5077) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8dbb1df differs from pull request most recent head e208a3e. Consider uploading reports for the commit e208a3e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1808   +/-   ##
=======================================
  Coverage   58.38%   58.39%           
=======================================
  Files          66       66           
  Lines        6705     6706    +1     
=======================================
+ Hits         3915     3916    +1     
  Misses       2790     2790           
Impacted Files Coverage Δ
...dis/montecarlo/montecarlo_numba/formal_integral.py 50.00% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b5077...e208a3e. Read the comment docs.

Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@andrewfullard andrewfullard merged commit a446d0e into tardis-sn:master Oct 25, 2021
@isaacgsmith isaacgsmith deleted the scipy_import_fix branch October 26, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants