-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing import for binder #1808
Fixing import for binder #1808
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
1 similar comment
Before a pull request is accepted, it must meet the following criteria:
|
Needs rebasing |
af31603
to
e208a3e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
=======================================
Coverage 58.38% 58.39%
=======================================
Files 66 66
Lines 6705 6706 +1
=======================================
+ Hits 3915 3916 +1
Misses 2790 2790
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge
Motivation and context
The way we imported
scipy.sparse.linalg
intardis/montecarlo/montecarlo_numba/formal_integral.py
caused errors in binder.How has this been tested?
Tested on binder, see below.
Examples
https://hub.gke2.mybinder.org/user/smithis7-tardis-hsplhrfd/lab/tree/docs/quickstart/quickstart.ipynb
Type of change
Checklist