remove numexpr

[wkerzendorf]

Many years ago - I used numexpr to speed up calculations - I don't think this is needed anymore.

[codecov]

Codecov Report

Merging #1821 (4fa8e11) into master (e4637d6) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 4fa8e11 differs from pull request most recent head 26a4c37. Consider uploading reports for the commit 26a4c37 to get more accurate results

@@            Coverage Diff             @@
##           master    #1821      +/-   ##
==========================================
+ Coverage   58.21%   58.22%   +0.01%     
==========================================
  Files          66       66              
  Lines        6729     6722       -7     
==========================================
- Hits         3917     3914       -3     
+ Misses       2812     2808       -4     

Impacted Files	Coverage Δ
tardis/tardis/plasma/properties/ion_population.py	85.64% <0.00%> (-0.08%)	⬇️
...s/tardis/plasma/properties/radiative_properties.py	79.02% <0.00%> (+1.83%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4637d6...26a4c37. Read the comment docs.

[tardis-bot]

Before a pull request is accepted, it must meet the following criteria:

• Is the necessary information provided?
• Is this a duplicate PR?
  • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
  • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
• Does it pass existing tests and are new tests provided if required?
  • The test coverage should not decrease, and for new features should be close to 100%.
• Is the code tidy?
  • No unnecessary print lines or code comments.

[Rodot-]

grepping for ne.evaluate turns up these locations:

tardis/plasma/properties/radiative_properties.py:93:        stimulated_emission_factor = ne.evaluate(
tardis/plasma/properties/radiative_properties.py:354:            transition_probabilites[start_id:end_id] *= 1 / ne.evaluate(
tardis/util/base.py:308:    intensity = ne.evaluate(

and for the imports

tardis/plasma/properties/ion_population.py:7:import numexpr as ne
tardis/plasma/properties/radiative_properties.py:5:import numexpr as ne
tardis/util/base.py:6:import numexpr as ne

[wkerzendorf]

this never was used anywhere - if tests pass then we should just remove that.

[epassaro]

Also try removing the dependency from the environment file @wkerzendorf

[wkerzendorf]

Also try removing the dependency from the environment file @wkerzendorf

there are still some other numexpr hiding out in TARDIS 😄