Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Default Log Level to INFO for the Simulation Logging #1843

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

DhruvSondhi
Copy link
Contributor

This PR aims to change the default log level to INFO and compare the changes with this setting for the simulation. Implementation for #1839.

Description
The default log level for the simulation logging is CRITICAL at the moment. This PR aims for change that to INFO wrt to Issue #1839. The intended change would show more information when the simulation is running & status of the simulation.

Motivation and context
Intended change for imparting more information to the user when the simulation is running.
But with this change in place, the intended usage of the Convergence Plots and Progress Bars is defeated. As more logs are outputted when the simulation is run, Jupyter notebook tends to scroll downwards and hence plots and progress bars cannot be scene. Also, scrolling when plots and logs are being output, it becomes buggy and slow. For more information check the video attached to compare the difference with this change and the original way of the log settings.

How has this been tested?

  • Testing pipeline.
  • Other.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

Original Log Level set to CRITICAL

Critical_log_level.mp4

Changes after setting the Log Level to INFO

Info_log_level.mp4

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1843 (ecb08c6) into master (f24be9a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1843   +/-   ##
=======================================
  Coverage   57.65%   57.65%           
=======================================
  Files          66       66           
  Lines        6809     6809           
=======================================
  Hits         3926     3926           
  Misses       2883     2883           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24be9a...ecb08c6. Read the comment docs.

@wkerzendorf wkerzendorf merged commit df8089c into tardis-sn:master Jan 25, 2022
@DhruvSondhi DhruvSondhi deleted the default_log_level branch January 26, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants